forked from ros2-java/ros2_java
-
Notifications
You must be signed in to change notification settings - Fork 9
Add OfferedDeadlineMissed QoS event #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
63 changes: 63 additions & 0 deletions
63
rcljava/include/org_ros2_rcljava_publisher_statuses_OfferedDeadlineMissed.h
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| // Copyright 2020 Open Source Robotics Foundation, Inc. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| #include <jni.h> | ||
| /* Header for class org_ros2_rcljava_publisher_statuses_OfferedDeadlineMissed */ | ||
|
|
||
| #ifndef ORG_ROS2_RCLJAVA_PUBLISHER_STATUSES_OFFEREDDEADLINEMISSED_H_ | ||
| #define ORG_ROS2_RCLJAVA_PUBLISHER_STATUSES_OFFEREDDEADLINEMISSED_H_ | ||
| #ifdef __cplusplus | ||
| extern "C" { | ||
| #endif | ||
|
|
||
| /* | ||
| * Class: org_ros2_rcljava_publisher_statuses_OfferedDeadlineMissed | ||
| * Method: nativeAllocateRCLStatusEvent | ||
| * Signature: ()J | ||
| */ | ||
| JNIEXPORT jlong JNICALL | ||
| Java_org_ros2_rcljava_publisher_statuses_OfferedDeadlineMissed_nativeAllocateRCLStatusEvent( | ||
| JNIEnv *, jclass); | ||
|
|
||
| /* | ||
| * Class: org_ros2_rcljava_publisher_statuses_OfferedDeadlineMissed | ||
| * Method: nativeDeallocateRCLStatusEvent | ||
| * Signature: (J)V | ||
| */ | ||
| JNIEXPORT void JNICALL | ||
| Java_org_ros2_rcljava_publisher_statuses_OfferedDeadlineMissed_nativeDeallocateRCLStatusEvent( | ||
| JNIEnv *, jclass, jlong); | ||
|
|
||
| /* | ||
| * Class: org_ros2_rcljava_publisher_statuses_OfferedDeadlineMissed | ||
| * Method: nativeFromRCLEvent | ||
| * Signature: (J)V | ||
| */ | ||
| JNIEXPORT void JNICALL | ||
| Java_org_ros2_rcljava_publisher_statuses_OfferedDeadlineMissed_nativeFromRCLEvent( | ||
| JNIEnv *, jobject, jlong); | ||
|
|
||
| /* | ||
| * Class: org_ros2_rcljava_publisher_statuses_OfferedDeadlineMissed | ||
| * Method: nativeGetPublisherEventType | ||
| * Signature: ()I | ||
| */ | ||
| JNIEXPORT jint JNICALL | ||
| Java_org_ros2_rcljava_publisher_statuses_OfferedDeadlineMissed_nativeGetPublisherEventType( | ||
| JNIEnv *, jclass); | ||
|
|
||
| #ifdef __cplusplus | ||
| } | ||
| #endif | ||
| #endif // ORG_ROS2_RCLJAVA_PUBLISHER_STATUSES_OFFEREDDEADLINEMISSED_H_ |
73 changes: 73 additions & 0 deletions
73
rcljava/src/main/cpp/org_ros2_rcljava_publisher_statuses_OfferedDeadlineMissed.cpp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,73 @@ | ||
| // Copyright 2020 Open Source Robotics Foundation, Inc. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| #include "org_ros2_rcljava_publisher_statuses_OfferedDeadlineMissed.h" | ||
|
|
||
| #include <jni.h> | ||
| #include <stdlib.h> | ||
|
|
||
| #include "rmw/types.h" | ||
| #include "rcl/event.h" | ||
| #include "rcljava_common/exceptions.hpp" | ||
|
|
||
| using rcljava_common::exceptions::rcljava_throw_exception; | ||
|
|
||
| JNIEXPORT jlong JNICALL | ||
| Java_org_ros2_rcljava_publisher_statuses_OfferedDeadlineMissed_nativeAllocateRCLStatusEvent( | ||
| JNIEnv * env, jclass) | ||
| { | ||
| void * p = malloc(sizeof(rmw_offered_deadline_missed_status_t)); | ||
| if (!p) { | ||
| rcljava_throw_exception( | ||
| env, "java/lang/OutOfMemoryError", "failed to allocate deadline missed status"); | ||
| } | ||
| return reinterpret_cast<jlong>(p); | ||
| } | ||
|
|
||
| JNIEXPORT void JNICALL | ||
| Java_org_ros2_rcljava_publisher_statuses_OfferedDeadlineMissed_nativeDeallocateRCLStatusEvent( | ||
| JNIEnv *, jclass, jlong handle) | ||
| { | ||
| free(reinterpret_cast<void *>(handle)); | ||
| } | ||
|
|
||
| JNIEXPORT void JNICALL | ||
| Java_org_ros2_rcljava_publisher_statuses_OfferedDeadlineMissed_nativeFromRCLEvent( | ||
| JNIEnv * env, jobject self, jlong handle) | ||
| { | ||
| auto * p = reinterpret_cast<rmw_offered_deadline_missed_status_t *>(handle); | ||
| if (!p) { | ||
| rcljava_throw_exception( | ||
| env, "java/lang/IllegalArgumentException", "passed rmw object handle is NULL"); | ||
| } | ||
| // TODO(ivanpauno): class and field lookup could be done at startup time | ||
| jclass clazz = env->GetObjectClass(self); | ||
| jfieldID total_count_fid = env->GetFieldID(clazz, "totalCount", "I"); | ||
| if (env->ExceptionCheck()) { | ||
| return; | ||
| } | ||
| jfieldID total_count_change_fid = env->GetFieldID(clazz, "totalCountChange", "I"); | ||
| if (env->ExceptionCheck()) { | ||
| return; | ||
| } | ||
| env->SetIntField(self, total_count_fid, p->total_count); | ||
| env->SetIntField(self, total_count_change_fid, p->total_count_change); | ||
| } | ||
|
|
||
| JNIEXPORT jint JNICALL | ||
| Java_org_ros2_rcljava_publisher_statuses_OfferedDeadlineMissed_nativeGetPublisherEventType( | ||
| JNIEnv *, jclass) | ||
| { | ||
| return RCL_PUBLISHER_OFFERED_DEADLINE_MISSED; | ||
| } |
65 changes: 65 additions & 0 deletions
65
rcljava/src/main/java/org/ros2/rcljava/publisher/statuses/OfferedDeadlineMissed.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,65 @@ | ||
| // Copyright 2020 Open Source Robotics Foundation, Inc. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package org.ros2.rcljava.publisher.statuses; | ||
|
|
||
| import java.util.function.Supplier; | ||
|
|
||
| import org.ros2.rcljava.common.JNIUtils; | ||
| import org.ros2.rcljava.events.PublisherEventStatus; | ||
|
|
||
| import org.slf4j.Logger; | ||
| import org.slf4j.LoggerFactory; | ||
|
|
||
| /** | ||
| * This class serves as a bridge between a rmw_offered_deadline_missed_status_t and RCLJava. | ||
| */ | ||
| public class OfferedDeadlineMissed implements PublisherEventStatus { | ||
| public int totalCount; | ||
| public int totalCountChange; | ||
|
|
||
| public final long allocateRCLStatusEvent() { | ||
| return nativeAllocateRCLStatusEvent(); | ||
| } | ||
| public final void deallocateRCLStatusEvent(long handle) { | ||
| nativeDeallocateRCLStatusEvent(handle); | ||
| } | ||
| public final void fromRCLEvent(long handle) { | ||
| nativeFromRCLEvent(handle); | ||
| } | ||
| public final int getPublisherEventType() { | ||
| return nativeGetPublisherEventType(); | ||
| } | ||
| // TODO(ivanpauno): Remove this when -source 8 can be used (method references for the win) | ||
| public static final Supplier<OfferedDeadlineMissed> factory = new Supplier<OfferedDeadlineMissed>() { | ||
| public OfferedDeadlineMissed get() { | ||
| return new OfferedDeadlineMissed(); | ||
| } | ||
| }; | ||
|
|
||
| private static final Logger logger = LoggerFactory.getLogger(OfferedDeadlineMissed.class); | ||
| static { | ||
| try { | ||
| JNIUtils.loadImplementation(OfferedDeadlineMissed.class); | ||
| } catch (UnsatisfiedLinkError ule) { | ||
| logger.error("Native code library failed to load.\n" + ule); | ||
| System.exit(1); | ||
| } | ||
| } | ||
|
|
||
| private static native long nativeAllocateRCLStatusEvent(); | ||
| private static native void nativeDeallocateRCLStatusEvent(long handle); | ||
| private native void nativeFromRCLEvent(long handle); | ||
| private static native int nativeGetPublisherEventType(); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I missed this for other statuses in previous PRs, but I think these member variables should be private and we can add getters for them. I think this will provide a bit better encapsulation (e.g. if symbol names change in the future, it's easier to deprecate a method than a member variable).
I don't think making them private has any impact on the native code setting their values.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that passive data types only carrying data are a valid citizen in oop.
When the class doesn't have any invariant (relationship between fields) there's not much value on using private data, setters and getters.
If we change the name of one of the members we're going to break all other clients, so I don't think that's going to happen.
I realized (late), that the generated java bindings for ROS messages doesn't expose the data and provides getters/setters instead.
Though I don't like that, maybe being consistent in event statuses is better.
If would prefer doing this change after merging all remaining PRs in the feature branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merged, we can solve this issue before merging the feature branch on master.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ambivalent about it. Maybe we just leave it as-is and bring it up again when we open a PR upstream.
I'm not sure what the reasoning was to generating getters and setters for ROS messages; this too may be something we can change later upstream.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good