Skip to content

Conversation

@lonvia
Copy link
Collaborator

@lonvia lonvia commented Jul 27, 2020

This only raises the version of libpq which osm2pgsql is linked against. Tests are still run against a Postgresql 9.6 installation. I was not able to get a later version running with Postgis.

@janhec Any chance that you could test that the new zip file works for you without deleting libpq.dll? A successfully compiled version can already be found in the appveyor runs of the branch.

Fixes #1199.

@mmd-osm
Copy link
Contributor

mmd-osm commented Jul 27, 2020

Quick feedback: osm2pgsql.exe doesn't start up on Win10, the following dlls seem to be missing in the zip file, according to the Windows error popups I'm getting:

gssapi64.dll
libcrypto-1_1-x64.dll
libssl-1_1-x64.dll

@lonvia
Copy link
Collaborator Author

lonvia commented Jul 27, 2020

Thanks @mmd-osm. That's what I was afraid of. Do you mind to do a couple of appveyor runs yourself and keep adding libraries in the after-build section until it works? The libraries you mention are all available in the conda directory. I've already run a listing of the directory in one of the try runs. You don't need to bother about the 32bit version if running it is an issue. We can just drop that part.

@mmd-osm
Copy link
Contributor

mmd-osm commented Jul 27, 2020

Ok, let's see what happens in #1259

@mmd-osm
Copy link
Contributor

mmd-osm commented Jul 27, 2020

Next round, adding 3 more dlls...

@mmd-osm
Copy link
Contributor

mmd-osm commented Jul 27, 2020

Adding another one... and we're good to go!


osm2pgsql.exe -V
osm2pgsql version 1.2.0

Compiled using the following library versions:
Libosmium 2.15.6
Lua 5.3.4

@lonvia
Copy link
Collaborator Author

lonvia commented Jul 27, 2020

Many thanks. I've cherry-picked the commits back to this PR and added a commit to disable 32bit builds.

@mmd-osm
Copy link
Contributor

mmd-osm commented Jul 27, 2020

By the way, you can test those generated Windows binaries on Linux on your own using wine (windows emulator). Wine prints loads of detailed error messages in case DLL dependencies cannot be satisfied.

wine ./osm2pgsql.exe -V
osm2pgsql version 1.2.0

Compiled using the following library versions:
Libosmium 2.15.6
Lua 5.3.4

@lonvia
Copy link
Collaborator Author

lonvia commented Jul 28, 2020

Fair point. :)

@lonvia lonvia merged commit 9552b96 into master Jul 28, 2020
@joto joto deleted the appveyor-test branch April 29, 2021 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows: update libpq version

3 participants