Consolidate NetBox device lookup into centralized utility #1826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create osism/utils/netbox.py with find_device_by_identifier() - Refactor 9 files to use centralized function: - osism/api.py - osism/commands/baremetal.py (5 locations) - osism/commands/sonic.py - osism/commands/console.py - osism/commands/netbox.py - osism/tasks/conductor/utils.py - osism/tasks/conductor/sonic/sync.py - osism/utils/ssh.py - Add comprehensive logging and error handling - Maintain backward compatibility This reduces code duplication by ~40 lines and improves maintainability by providing a single source of truth for device lookup operations. AI-assisted: Claude Code Signed-off-by: Christian Berendt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces code duplication by ~40 lines and improves maintainability by providing a single source of truth for device lookup operations.
AI-assisted: Claude Code