Add timezone support for booking date parsing in BrndFeedType #333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuj
requested changes
Nov 26, 2025
Contributor
Author
|
BRND is a system that is sold exclusively to Danish municipalities. It is an IT system built around Foreningsloven and the rules for "foreningsrefusion". We do not have the ability to configure the time zone. |
tuj
approved these changes
Nov 26, 2025
tuj
requested changes
Nov 27, 2025
That is a fine idea. I just dont have time to do it before thursday or friday next week. Co-authored-by: Troels Ugilt Jensen <[email protected]>
Open
tuj
requested changes
Dec 4, 2025
|
|
||
| private function parseBrndBooking(array $booking): array | ||
| { | ||
| $tz = new \DateTimeZone(self::BRND_API_TIMEZONE); |
Contributor
There was a problem hiding this comment.
You need to manually add this constant to the top of the class, for the code to work:
/* BRND api datetime values are always given as 'Europe/Copenhagen' */
private const string BRND_API_TIMEZONE = 'Europe/Copenhagen';
tuj
approved these changes
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket
Fixes #327
Description
Use the Europe/Copenhagen timezone when parsing dates and times.