When '--builder' isn't specified, use the WLSIMG_BUILDER env var... #393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he build engine (if set). Continue to use 'docker' otherwise.
oracle-contributor-agreement
bot
added
the
OCA Verified
ddsharpe
approved these changes
Oct 3, 2022
| @@ -24,7 +24,7 @@ Usage: imagetool createAuxImage [OPTIONS] | |||
| | `--tag` | (Required) Tag for the final build image. Example: `store/oracle/mydomain:1` | | | |||
| | `--additionalBuildCommands` | Path to a file with additional build commands. For more details, see [Additional information](#--additionalbuildcommands). | | |||
| | `--additionalBuildFiles` | Additional files that are required by your `additionalBuildCommands`. A comma separated list of files that should be copied to the build context. See [Additional information](#--additionalbuildfiles). | | |||
| | `--builder`, `-b` | Executable to process the Dockerfile. Use the full path of the executable if not on your path. | `docker` | | |||
| | `--builder`, `-b` | Executable to process the Dockerfile. Use the full path of the executable if not on your path. | Defaults to 'docker', or, when set, to the value in environment variable WLSIMG_BUILDER. | | |||
There was a problem hiding this comment.
WLSIMG_BUILDER -> WLSIMG_BUILDER (env variable should be in code font; please correct globally)
There was a problem hiding this comment.
Done. Also changed 'docker' to docker.
| @@ -16,7 +16,7 @@ Usage: imagetool inspect [OPTIONS] | |||
| | Parameter | Definition | Default | | |||
| | --- | --- | --- | | |||
| | `--image`, `-i` | (Required) The image ID or image name to be inspected. | | | |||
| | `--builder`, `-b` | Executable to process the Dockerfile. Use the full path of the executable if not on your path. | `docker` | | |||
| | `--builder`, `-b` | Executable to inspect docker images. Use the full path of the executable if not on your path. | Defaults to 'docker', or, when set, to the value in environment variable WLSIMG_BUILDER. | | |||
|
Kudos, SonarCloud Quality Gate passed! |
rosemarymarano
approved these changes
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…as the build engine (if set). Continue to use 'docker' otherwise.