Skip to content

Perform final filtering on full, merged model #1398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 23, 2023
Merged

Conversation

rakillen
Copy link
Member

@rakillen rakillen commented Feb 22, 2023

  • For create and prepare, check server template assignments, regardless of target.

  • For discover and prepare with wko targets, check dynamic cluster server name prefixes. Add default values for missing prefixes, issue a warning for duplicate prefixes.

  • For discover and prepare with wko version 3 targets, check admin server name and definition. Add default admin server name if missing, add empty definition with derived name if missing.

  • Corrections to prepare model are applied to the last (or only) model in the list.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Feb 22, 2023
@rakillen rakillen requested a review from jshum2479 February 22, 2023 16:55
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@ddsharpe ddsharpe merged commit 4c1c7d5 into main Feb 23, 2023
@ddsharpe ddsharpe deleted the full-model-filter branch February 23, 2023 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants