Skip to content

Conversation

@idodeclare
Copy link
Contributor

Hello,

Please consider for integration this patch to add a Verilog analyzer requested eagerly by a couple of folks a few months ago.

Also, I patched some additional nits found while testing:

  • Do not throw if source file unavailable for Context.
  • Output --help to stdout not stderr, with EXIT STATUS=0.
  • Show full path when logging missing xref.
  • Short-circuit option -R if --help|-h|-? is used.

Thank you.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3997

  • 297 of 309 (96.12%) changed or added relevant lines in 7 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.2%) to 73.557%

Changes Missing Coverage Covered Lines Changed/Added Lines %
opengrok-indexer/src/main/java/org/opengrok/indexer/index/IndexDatabase.java 2 3 66.67%
opengrok-indexer/src/main/java/org/opengrok/indexer/search/Results.java 0 4 0.0%
opengrok-indexer/src/main/java/org/opengrok/indexer/index/Indexer.java 5 12 41.67%
Files with Coverage Reduction New Missed Lines %
opengrok-indexer/src/main/java/org/opengrok/indexer/index/IndexDatabase.java 1 54.36%
opengrok-indexer/src/main/java/org/opengrok/indexer/search/Results.java 2 0.0%
Totals Coverage Status
Change from base Build 3993: 0.2%
Covered Lines: 33565
Relevant Lines: 45631

💛 - Coveralls

@tarzanek tarzanek added this to the 1.2 milestone Feb 10, 2019
@tarzanek
Copy link
Contributor

lgtm, merging

@tarzanek tarzanek merged commit 8ee2396 into oracle:master Feb 10, 2019
@idodeclare idodeclare deleted the feature/verilog branch February 10, 2019 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants