[GR-47109] Support JFR event ObjectAllocationSample. #8316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…test of distribution
… fields by lock access. Restrict access in JfrThrottler.
minor clean up
clean up JFR random
style
oracle-contributor-agreement
bot
added
the
OCA Verified
| return false; | ||
| } | ||
|
|
||
| return activeWindow.sample(); |
There was a problem hiding this comment.
hi @christianhaeubl this reverts the read-write lock changes. Doesn't this still have the same problems you were concerned about (#6899 (comment)).
A window may expire after a thread has checked expiry status but before it has sampled with respect to it.
There was a problem hiding this comment.
Yes, I removed the read/write lock because I don't think that this race can cause any relevant problems (that is probably also the reason why HotSpot doesn't guard against it).
|
Thank you for working on integrating this. Apart from my comment above, the sampling logic and tests all seem fine to me. |
|
Thanks for double-checking. |
graalvmbot
force-pushed
the
chaeubl/GR-47109
branch
from
2784ab6 to
cf93204
Compare
roberttoyonaga
approved these changes
Feb 7, 2024
graalvmbot
force-pushed
the
chaeubl/GR-47109
branch
from
cf93204 to
103af23
Compare
graalvmbot
force-pushed
the
chaeubl/GR-47109
branch
from
103af23 to
d721c1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #6899. This PR contains larger cleanups and changes the code so that it is a lot closer to the original C++ sources (makes maintenance easier).
@roberttoyonaga : please double-check this PR and let me know if I removed anything relevant.