[GR-45281] Preprocess _MSC_FULL_VER to detect cl.exe version info.
#8058
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`distutils` is removed from Python 3.12.
The previous approach relied on the version string of `cl.exe`, which is localized and thus not always correctly detected when the system language is not English.
oracle-contributor-agreement
bot
added
the
OCA Verified
graalvmbot
force-pushed
the
fniephaus/GR-45281/cl-version-check
branch
from
c7c3aed to
3a00ce6
Compare
This was referenced Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous approach relied on the version string of
cl.exe, which is localized and thus not always correctly detected when the system language is not English.