Support for lambda class serialization #3792

filozof50 · 2021-09-13T14:20:03Z

In order to serialize and deserialize lambdas, methods serializeLambda (from lambda instance) and deserializeLambda (from class that captures lambda) needs to be registered for the runtime reflection. This is done in SerializationFeature class.

We have to make distinction between classes that needs to be registered for serialization and capturing classes that captures lambdas,
so in this PR new attribute for serialization-config.json file is intorduced as following:

"lambdaCapturingClass":CAPTURING_CLASS_NAME

The agent has been changed accordingly.

We also introduced new format for serialization configuration files in native image.

Example of the new format in serilaization configuration file can be found in the following file:
substratevm/src/com.oracle.svm.core/src/com/oracle/svm/core/configure/doc-files/SerializationConfigurationFilesHelp.txt

oubidar-Abderrahim · 2021-09-17T14:54:31Z

Thank you for contributing to GraalVM, this PR is tracked by GR-33824

vjovanov · 2021-09-21T13:46:05Z

...vm/src/com.oracle.svm.reflect/src/com/oracle/svm/reflect/serialize/SerializationSupport.java

+                declaringClass = Class.forName("java.lang.invoke.SerializedLambda");
+                // Checkstyle: resume
+            } catch (ClassNotFoundException e) {
+                e.printStackTrace();


We should use VMError.shouldNotReachHere

Fixed as suggested.

vjovanov · 2021-09-21T13:46:46Z

...com.oracle.svm.reflect/src/com/oracle/svm/reflect/serialize/hosted/SerializationFeature.java

+                        Method serializeLambdaMethod = type.getJavaClass().getDeclaredMethod("writeReplace");
+                        RuntimeReflection.register(serializeLambdaMethod);
+                    } catch (NoSuchMethodException e) {
+                        VMError.shouldNotReachHere("You have to register class from which you want lambdas to be serialized.");


Use throw VMError.shouldNotReachHere in front so IDEs don't get confused.

Fixed as suggested.

vjovanov · 2021-09-21T13:52:17Z

...com.oracle.svm.reflect/src/com/oracle/svm/reflect/serialize/hosted/SerializationFeature.java

+            try {
+                RuntimeReflection.register(serializationTargetClass.getDeclaredMethod("$deserializeLambda$", SerializedLambda.class));
+            } catch (NoSuchMethodException e) {
+                VMError.shouldNotReachHere("Method named $deserializeLambda$ must exist in capturing class (" + serializationTargetClass.getName() + ") of lambdas that have writeReplace method.");


in the capturing class ... the writeReplace method

Fixed as suggested.

vjovanov · 2021-09-21T13:56:51Z

There is a segfault in one of the benchmarks when running with the agent:

mx --env ni-ce --kill-with-sigquit benchmark renaissance-native-image:page-rank -- --jvm=native-image --jvm-config=default-ce -Dnative-image.benchmark.extra-run-arg=-Xmx8g -- -r 1```

vjovanov · 2021-09-21T13:58:34Z

substratevm/src/com.oracle.svm.agent/src/com/oracle/svm/agent/BreakpointInterceptor.java

@@ -878,6 +878,76 @@ private static JNIObjectHandle shouldIncludeMethod(JNIEnvironment jni, JNIObject
        return result;
    }

+    private static boolean registerCapturingClass(JNIEnvironment jni, Breakpoint bp, InterceptedState state) {


It is hard for me to follow this code. I think a concise comment about what happens here would be nice. Alternatively, split the method in several calls that have a descriptive name.

Comment added as suggested.

vjovanov · 2021-09-21T14:08:32Z

substratevm/src/com.oracle.svm.agent/src/com/oracle/svm/agent/BreakpointInterceptor.java

+         * recursively. Call ObjectStreamClass.getClassDataLayout0() can get all of them.
+         */
+
+        JNIMethodId getClassDataLayout0MId = agent.handles().getJavaIoObjectStreamClassGetClassDataLayout0(jni, bp.clazz);


This would be a good candidate as there is almost the same segment in: com.oracle.svm.agent.BreakpointInterceptor#objectStreamClassConstructor

New method created and called in all the places needed.

This method has been removed in the last commit. When we get to SerializedLambda#readResolve method, method on ObjectStreamClass has already been called for proper capturing class. So, we do not need to search recursively again in that case and this method is sufficient now. We only need this check here, not in other places in code.

vjovanov · 2021-09-21T14:11:08Z

...com.oracle.svm.configure/src/com/oracle/svm/configure/config/SerializationConfiguration.java

@@ -85,7 +86,8 @@ public void registerWithTargetConstructorClass(ConfigurationCondition condition,
    }

    @Override
-    public void registerWithTargetConstructorClass(ConfigurationCondition condition, String className, String customTargetConstructorClassName) {
+    public void registerWithTargetConstructorClass(ConfigurationCondition condition, String rawClassName, String customTargetConstructorClassName) {
+        String className = rawClassName.contains("$$Lambda$") ? rawClassName.split(LambdaUtils.SPLIT_BY_LAMBDA)[0] + "$$Lambda$" : rawClassName;


"$$Lambda$" is a good candidate for LambdaUtils

Added to LambdaUtils as suggested.

vjovanov · 2021-09-21T14:14:26Z

...oracle.svm.configure/src/com/oracle/svm/configure/config/SerializationConfigurationType.java

@@ -55,7 +56,14 @@ public SerializationConfigurationType(ConfigurationCondition condition, String q
    public void printJson(JsonWriter writer) throws IOException {
        writer.append('{').indent().newline();
        ConfigurationConditionPrintable.printConditionAttribute(condition, writer);
-        writer.quote(SerializationConfigurationParser.NAME_KEY).append(':').quote(qualifiedJavaName);
+
+        if (qualifiedJavaName.contains("$$Lambda$") && !qualifiedJavaName.contains("/")) {


I think abusing qualifiedJavaName is not necessary here. It can also lead to duplicates during writing. We need to put the new value properly in the model and then change the equality function to compare that as well.

Also, we need assertions that both can't be populated.

New attribute isLambdaCapturingClass added to distinct lambda capturing classes from classes that should be registered for serialization.
Assertion added as suggested.

vjovanov · 2021-09-21T14:18:17Z

.../com.oracle.svm.core/src/com/oracle/svm/core/configure/SerializationConfigurationParser.java

@@ -58,9 +59,10 @@ public void parseAndRegister(Reader reader) throws IOException {
    }

    private void parseSerializationDescriptorObject(Map<String, Object> data) {
-        checkAttributes(data, "serialization descriptor object", Collections.singleton(NAME_KEY), Arrays.asList(CUSTOM_TARGET_CONSTRUCTOR_CLASS_KEY, CONDITIONAL_KEY));
+        checkMultipleOptionsAttributes(data, "serialization descriptor object", Collections.unmodifiableCollection(Arrays.asList(NAME_KEY, LAMBDA_CAPTURING_CLASS_KEY)),


Multiple is not accurate. They are exclusive options so maybe checkExclusiveOptionsAttributes.

This is also not overly general as it supports only a single option.

What happened to Arrays.asList(CUSTOM_TARGET_CONSTRUCTOR_CLASS_KEY, CONDITIONAL_KEY)?

Multiple is not accurate. They are exclusive options so maybe checkExclusiveOptionsAttributes.

This is also not overly general as it supports only a single option.

Changed as suggested.

What happened to Arrays.asList(CUSTOM_TARGET_CONSTRUCTOR_CLASS_KEY, CONDITIONAL_KEY)?

It's been removed by mistake.

vjovanov · 2021-09-21T14:20:22Z

...vm/src/com.oracle.svm.reflect/src/com/oracle/svm/reflect/serialize/SerializationSupport.java

+        if (declaringClass.getName().contains("$$Lambda$")) {
+            try {
+                // Checkstyle: stop
+                declaringClass = Class.forName("java.lang.invoke.SerializedLambda");


Can we fetch this once in a final field?

Added final field serializedLambdaClass and used in proper places.

graalvmbot · 2021-09-24T09:00:17Z

Hello filozof50, thanks for contributing a PR to our project!

We use the Oracle Contributor Agreement to make the copyright of contributions clear. We don't have a record of you having signed this yet, based on your email address strahinja_stanojevic -(at)- matf -(dot)- bg -(dot)- ac -(dot)- rs. You can sign it at that link.

If you think you've already signed it, please comment below and we'll check.

filozof50 · 2021-09-26T19:44:15Z

There is a segfault in one of the benchmarks when running with the agent:

mx --env ni-ce --kill-with-sigquit benchmark renaissance-native-image:page-rank -- --jvm=native-image --jvm-config=default-ce -Dnative-image.benchmark.extra-run-arg=-Xmx8g -- -r 1```

It's been fixed now.

vjovanov · 2021-09-28T13:09:37Z

compiler/src/org.graalvm.compiler.java/src/org/graalvm/compiler/java/LambdaUtils.java

@@ -51,6 +51,8 @@
 public final class LambdaUtils {
    private static final Pattern LAMBDA_PATTERN = Pattern.compile("\\$\\$Lambda\\$\\d+[/\\.][^/]+;");
    private static final char[] HEX = "0123456789abcdef".toCharArray();
+    public static final String SPLIT_BY_LAMBDA = "\\$\\$Lambda\\$";


This can be expressed as Pattern.quote(LAMBDA_FUNCTIONS_NAME_PATTERN).

LAMBDA_SPLIT_PATTERN would be better.

This can be expressed as Pattern.quote(LAMBDA_FUNCTIONS_NAME_PATTERN).

It cannot. LambdaUtils class is needed in runtime, so this should stay String in order to finish build process successfully.

LAMBDA_SPLIT_PATTERN would be better.

Changed as suggested.

vjovanov · 2021-09-28T13:10:14Z

compiler/src/org.graalvm.compiler.java/src/org/graalvm/compiler/java/LambdaUtils.java

@@ -51,6 +51,8 @@
 public final class LambdaUtils {
    private static final Pattern LAMBDA_PATTERN = Pattern.compile("\\$\\$Lambda\\$\\d+[/\\.][^/]+;");
    private static final char[] HEX = "0123456789abcdef".toCharArray();
+    public static final String SPLIT_BY_LAMBDA = "\\$\\$Lambda\\$";
+    public static final String LAMBDA_FUNCTIONS_NAME_PATTERN = "$$Lambda$";


LAMBDA_CLASS_NAME_PATTERN is maybe more accurate.

Why don't we use the LAMBDA_PATTERN above?

LAMBDA_CLASS_NAME_PATTERN is maybe more accurate.

Changed as suggested.

Why don't we use the LAMBDA_PATTERN above?

I expects ; at the end (not optional) which is not case in cases which are important for this PR. So, we need 2 new constants in LambdaUtils class.

vjovanov · 2021-09-28T13:30:36Z

compiler/src/org.graalvm.compiler.java/src/org/graalvm/compiler/java/LambdaUtils.java

@@ -51,6 +51,8 @@
 public final class LambdaUtils {
    private static final Pattern LAMBDA_PATTERN = Pattern.compile("\\$\\$Lambda\\$\\d+[/\\.][^/]+;");


Can't we use this one for all we need?

No, the explanation is in the comment above.

vjovanov · 2021-09-28T13:33:11Z

substratevm/src/com.oracle.svm.core/src/com/oracle/svm/core/configure/ConfigurationParser.java

+        checkRemainingAttributes(map, type, requiredAttrs, optionalAttrs, unseenRequired);
+    }
+
+    protected void warnOrFail(String message) {


No need to move these functions, it will just mess up the history.

Order of the functions is not changed now (comparing to master branch).

Not true, you moved warnOrFail and checkAttributes before checkRemainingAttributes. Please move it back.

vjovanov · 2021-09-28T13:39:37Z

substratevm/src/com.oracle.svm.agent/src/com/oracle/svm/agent/BreakpointInterceptor.java

@@ -1000,8 +1029,10 @@ private static boolean objectStreamClassConstructor(JNIEnvironment jni, Breakpoi
         * additional ObjectStreamClass instances (usually the super classes) are created
         * recursively. Call ObjectStreamClass.getClassDataLayout0() can get all of them.
         */
+


Unrelated changes.

vjovanov · 2021-09-28T13:41:19Z

...com.oracle.svm.configure/src/com/oracle/svm/configure/config/SerializationConfiguration.java

-    public void registerWithTargetConstructorClass(ConfigurationCondition condition, String className, String customTargetConstructorClassName) {
-        serializations.add(createConfigurationType(condition, className, customTargetConstructorClassName));
+    public void registerWithTargetConstructorClass(ConfigurationCondition condition, String rawClassName, String customTargetConstructorClassName) {
+        String className = rawClassName.contains(LambdaUtils.LAMBDA_FUNCTIONS_NAME_PATTERN) ? rawClassName.split(LambdaUtils.SPLIT_BY_LAMBDA)[0] + LambdaUtils.LAMBDA_FUNCTIONS_NAME_PATTERN


I don't see a need for appending $$Lambda$ here as you already have the boolean. I would keep the class name as is.

I agree, fixed as suggested.

vjovanov · 2021-09-28T13:41:45Z

...com.oracle.svm.configure/src/com/oracle/svm/configure/config/SerializationConfiguration.java

-        return serializations.contains(createConfigurationType(condition, serializationTargetClass, customTargetConstructorClass));
+    public boolean contains(ConfigurationCondition condition, String rawSerializationTargetClass, String customTargetConstructorClass) {
+        String serializationTargetClass = rawSerializationTargetClass.contains(LambdaUtils.LAMBDA_FUNCTIONS_NAME_PATTERN)
+                        ? rawSerializationTargetClass.split(LambdaUtils.SPLIT_BY_LAMBDA)[0] + LambdaUtils.LAMBDA_FUNCTIONS_NAME_PATTERN


Here as well.

Fixed as suggested.

peter-hofer · 2021-12-20T20:27:51Z

...com.oracle.svm.configure/src/com/oracle/svm/configure/config/SerializationConfiguration.java

+        if (types.equals("types")) {
+            printSerializationTypes(writer);
+        } else {
+            printLambdaCapturingSerializationTypes(writer);
+        }


It would be cleaner to pass in a Consumer<JsonWriter> to call, or since printSerializationTypes and printLambdaCapturingSerializationTypes is essentially the same, you could pass them as a JsonPrintable array or collection.
But I think you should actually be able to use JsonPrinter.printCollection here.

I used JsonPrintable list to make an abstraction here.

peter-hofer · 2021-12-20T20:36:26Z

...igure/src/com/oracle/svm/configure/config/SerializationConfigurationLambdaCapturingType.java

+    }
+
+    @Override
+    public int compareTo(SerializationConfigurationLambdaCapturingType other) {


I think you should instead use an actual Comparator class.

Used as suggested.

peter-hofer · 2021-12-20T20:37:30Z

...oracle.svm.configure/src/com/oracle/svm/configure/config/SerializationConfigurationType.java

@@ -89,10 +90,13 @@ public int compareTo(SerializationConfigurationType other) {
        if (compareName != 0) {
            return compareName;
        }
-        int compareCondition = condition.compareTo(other.condition);
+
+        int compareCondition = condition.compareTo(condition);


Doesn't look like it...

peter-hofer · 2021-12-20T20:46:28Z

.../com.oracle.svm.core/src/com/oracle/svm/core/configure/SerializationConfigurationParser.java

+        }
+    }
+
+    private void parseSerializationDescriptorObject(Map<String, Object> data, boolean lambdaCapturingType) {
        checkAttributes(data, "serialization descriptor object", Collections.singleton(NAME_KEY), Arrays.asList(CUSTOM_TARGET_CONSTRUCTOR_CLASS_KEY, CONDITIONAL_KEY));


This should not accept a target constructor for lambda-capturing types.

Removed as suggested.

peter-hofer · 2021-12-20T20:49:08Z

.../com.oracle.svm.core/src/com/oracle/svm/core/configure/SerializationConfigurationParser.java

+    private void parseSerializationTypes(List<Object> listOfSerializationTypes) {
+        for (Object serializationType : listOfSerializationTypes) {
+            parseSerializationDescriptorObject(asMap(serializationType, "third level of document must be serialization descriptor objects"), false);
+        }
+    }
+
+    private void parseLambdaCapturingTypes(List<Object> listOfLambdaCapturingTypes) {
+        for (Object lambdaCapturingType : listOfLambdaCapturingTypes) {
+            parseSerializationDescriptorObject(asMap(lambdaCapturingType, "third level of document must be serialization descriptor objects"), true);
+        }
+    }


Simply pass a boolean instead of having two methods.

Used an additional argument as suggested.

peter-hofer · 2021-12-20T21:02:20Z

substratevm/src/com.oracle.svm.test/src/com/oracle/svm/test/LambdaClassSerializationTest.java

+    private static final ByteArrayOutputStream byteArrayOutputStream;
+
+    static {
+        byteArrayOutputStream = new ByteArrayOutputStream();
+    }


I doubt this is necessary and you should be able to create the stream in the test method and pass it to the serialize and deserialize methods.

Stream passed as an argument.

peter-hofer · 2021-12-20T21:02:59Z

substratevm/src/com.oracle.svm.test/src/com/oracle/svm/test/LambdaClassDeserializationTest.java

+    private static final ByteArrayOutputStream byteArrayOutputStream;
+
+    static {
+        byteArrayOutputStream = new ByteArrayOutputStream();
+    }


I doubt this is necessary and you should be able to create the stream in the test method and pass it to the respective methods.

Stream passed as an argument.

peter-hofer · 2021-12-20T21:04:28Z

substratevm/src/com.oracle.svm.test/src/com/oracle/svm/test/LambdaClassDeserializationTest.java

+            Function<Integer, String> fn = (Function<Integer, String>) objectInputStream.readObject();
+            return fn;


Why cast when you return Object?

Cast removed as suggested.

peter-hofer · 2021-12-20T21:05:30Z

...com.oracle.svm.reflect/src/com/oracle/svm/reflect/serialize/hosted/SerializationFeature.java


 @AutomaticFeature
 public class SerializationFeature implements Feature {
+    static final HashSet<Class<?>> capturingClasses = new HashSet<>();


Shouldn't be static.

It has to be, because it is being referenced from inner class SerializationBuilder.

peter-hofer · 2021-12-20T21:08:06Z

substratevm/src/com.oracle.svm.agent/src/com/oracle/svm/agent/BreakpointInterceptor.java

        }
        return true;
    }

+    private static boolean isSerializable(JNIEnvironment env, JNIObjectHandle serializeTargetClass) {
+        JNIObjectHandle javaIoSerializable = agent.handles().findClass(env, "java/io/Serializable");


But it's still not a lazy lookup.

peter-hofer · 2021-12-20T21:22:01Z

...com.oracle.svm.reflect/src/com/oracle/svm/reflect/serialize/hosted/SerializationFeature.java

+     * which is of type {@code DirectHotSpotObjectConstantImpl}. That class is protected and it is
+     * not visible in the {@link SerializationFeature}. The only way to access fields and methods of
+     * this class is through the reflection. There are 2 different ways of getting lambda from the
+     * {@code ConstantNode#value}:


You need to go through SnippetReflectionProvider.asObject. You get the provider via GraalAccess.getOriginalProviders that you already call elsewhere.

SnippetReflectionProvider.asObject used as suggested.

peter-hofer · 2021-12-20T21:39:56Z

...com.oracle.svm.reflect/src/com/oracle/svm/reflect/serialize/hosted/SerializationFeature.java

+     * 1. For capturing classes from the JDK {@code ConstantNode#value} of type
+     * {@code DirectHotSpotObjectConstantImpl} has {@code DirectHotSpotObjectConstantImpl#object} of
+     * type {@code DirectMethodHandle$Constructor} on Java 17 and in previous versions. Lambda class
+     * can be extracted from {@code DirectMethodHandle$Constructor#initMethod} using the
+     * {@code MemberName#getDeclaringClass()} or from {@code DirectMethodHandle#member} using the
+     * {@code MemberName#getDeclaringClass()}. Since all of those classes are protected and are not
+     * in the same package as the {@link SerializationFeature}, the only way to get the lambda class
+     * is using the reflection.
+     *
+     * 2. For capturing classes that are user-defined classes, {@code ConstantNode#value} of type
+     * {@code DirectHotSpotObjectConstantImpl} has {@code DirectHotSpotObjectConstantImpl#object} of
+     * type {@code DirectMethodHandle$StaticAccessor} type. In that case, lambda class is stored in
+     * the {@code DirectMethodHandle$StaticAccessor#staticBase}. Since
+     * {@code DirectMethodHandle$StaticAccessor} is also protected class and cannot be imported in
+     * the {@link SerializationFeature}, it is not possible to get values from this field in any
+     * ways other than the reflection.


It doesn't seem plausible that this is the only way. Instead, it should be possible to get the declaring class of a constructor method handle by calling type().returnType() on it.

type.returnType() does not return what we expected it would. But I used some other reflection providers to get all the relevant information and to get lambdas from registered capturing classes.

…zof50/graal into lambda-serialization-branch

vjovanov · 2022-01-31T09:38:01Z

...igure/src/com/oracle/svm/configure/config/SerializationConfigurationLambdaCapturingType.java

+
+    public SerializationConfigurationLambdaCapturingType(ConfigurationCondition condition, String qualifiedJavaName) {
+        assert qualifiedJavaName.indexOf('/') == -1 : "Requires qualified Java name, not internal representation";
+        assert !qualifiedJavaName.startsWith("[") : "Requires Java source array syntax, for example java.lang.String[]";


The text doesn't make sense to me.

How can an array be a capturing type?

You are right, it doesn't make sense. It's been removed.

vjovanov · 2022-01-31T09:38:32Z

...igure/src/com/oracle/svm/configure/config/SerializationConfigurationLambdaCapturingType.java

+    private final String qualifiedJavaName;
+
+    public SerializationConfigurationLambdaCapturingType(ConfigurationCondition condition, String qualifiedJavaName) {
+        assert qualifiedJavaName.indexOf('/') == -1 : "Requires qualified Java name, not internal representation";


The articles are missing.

Added as suggested.

vjovanov · 2022-01-31T10:29:53Z

substratevm/src/com.oracle.svm.test/src/META-INF/native-image/serialization-config.json

+    }
+  ]
+}


Missing EOL.

Added as suggested.

vjovanov · 2022-01-31T10:40:13Z

...rc/com.oracle.svm.test/src/META-INF/native-image/com.oracle.svm.test/native-image.properties

-  -H:+AllowVMInspection \
-  --features=com.oracle.svm.test.AbstractServiceLoaderTest$TestFeature,com.oracle.svm.test.NoProviderConstructorServiceLoaderTest$TestFeature \
-  --add-exports=org.graalvm.nativeimage.builder/com.oracle.svm.core.containers=ALL-UNNAMED
+Args=--initialize-at-run-time=com.oracle.svm.test --initialize-at-build-time=com.oracle.svm.test.AbstractClassSerializationTest,com.oracle.svm.test.SerializationRegistrationTest,com.oracle.svm.test.LambdaClassSerializationTest,com.oracle.svm.test.LambdaClassDeserializationTest --features=com.oracle.svm.test.SerializationRegistrationTestFeature -H:+AllowVMInspection --features=com.oracle.svm.test.AbstractServiceLoaderTest$TestFeature,com.oracle.svm.test.NoProviderConstructorServiceLoaderTest$TestFeature --features=com.oracle.svm.test.SerializationRegistrationTestFeature -H:+AllowVMInspection --features=com.oracle.svm.test.AbstractServiceLoaderTest$TestFeature,com.oracle.svm.test.NoProviderConstructorServiceLoaderTest$TestFeature --add-exports=org.graalvm.nativeimage.builder/com.oracle.svm.core.containers=ALL-UNNAMED


Seems like an unrelated change?

I actually added 2 classes for build time initialization.

vjovanov · 2022-01-31T10:53:47Z

...com.oracle.svm.reflect/src/com/oracle/svm/reflect/serialize/hosted/SerializationFeature.java

+    private static StructuredGraph createMethodGraph(ResolvedJavaMethod method, DebugContext debug) {
+        StructuredGraph graph = new StructuredGraph.Builder(debug.getOptions(), debug).method(method).build();
+        try (DebugContext.Scope ignored = debug.scope("ParsingToMaterializeLambdas")) {
+            GraphBuilderPhase lambdaParserPhase = new GraphBuilderPhase(buildLambdaParserConfig());


You could also put the GraphBuilderPhase in the abstraction.

Moved as suggested.

zakkak · 2022-06-03T16:41:24Z

It looks like this PR has been integrated as b455f23.

Could someone please verify and close the PR if that's true?

graalvmbot added the oca-signed label Sep 13, 2021

oubidar-Abderrahim self-assigned this Sep 17, 2021

oubidar-Abderrahim requested a review from christianwimmer September 17, 2021 14:53

christianwimmer requested review from vjovanov and peter-hofer September 17, 2021 16:01

vjovanov reviewed Sep 21, 2021

View reviewed changes

filozof50 force-pushed the lambda-serialization-branch branch 4 times, most recently from b307da0 to c2ce091 Compare September 26, 2021 19:06

vjovanov reviewed Sep 28, 2021

View reviewed changes

filozof50 force-pushed the lambda-serialization-branch branch from c2ce091 to baf5656 Compare September 30, 2021 12:17

filozof50 added 2 commits December 10, 2021 16:56

Added explanations for using reflection during method parsing.

1753252

Help file for serialiation edited.

541c200

peter-hofer reviewed Dec 20, 2021

View reviewed changes

peter-hofer requested changes Dec 20, 2021

View reviewed changes

filozof50 added 15 commits January 20, 2022 08:35

Merging

221904b

Review changes made

c45e8f6

Merging

186af89

Merge branch 'master' into lambda-serialization-branch

584076d

Style changes

ae4744f

Merge branch 'lambda-serialization-branch' of https://github.com/filo…

e6df7fa

…zof50/graal into lambda-serialization-branch

Sufficient comments removed

fca81bc

Merge branch 'oracle:master' into lambda-serialization-branch

79b1624

Style changes

7e580bb

Style changes

f06a76e

Update SerializationConfiguration.java

1c6530b

Merge branch 'lambda-serialization-branch' of https://github.com/filo…

8934767

…zof50/graal into lambda-serialization-branch

Style minor changes

258dd8b

Minor style changes

82af5a4

Minor style changes

c3ae380

vjovanov reviewed Jan 31, 2022

View reviewed changes

filozof50 changed the title ~~WIP: Support for lambda functions serialization added~~ Support for lambda class serialization Jan 31, 2022

vjovanov reviewed Jan 31, 2022

View reviewed changes

filozof50 added 3 commits January 31, 2022 12:45

Review changes

e3de038

Merge branch 'master' into lambda-serialization-branch

8765cdc

Registering all the lambdas from constructors too

93e47e1

vjovanov closed this Jun 8, 2022

		@@ -51,6 +51,8 @@
		public final class LambdaUtils {
		private static final Pattern LAMBDA_PATTERN = Pattern.compile("\\$\\$Lambda\\$\\d+[/\\.][^/]+;");

		Function<Integer, String> fn = (Function<Integer, String>) objectInputStream.readObject();
		return fn;

Support for lambda class serialization #3792

Support for lambda class serialization #3792

Uh oh!

Conversation

filozof50 commented Sep 13, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oubidar-Abderrahim commented Sep 17, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vjovanov Sep 21, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vjovanov commented Sep 21, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

filozof50 Sep 24, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

graalvmbot commented Sep 24, 2021

Uh oh!

filozof50 commented Sep 26, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

filozof50 Sep 30, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

filozof50 commented Sep 13, 2021 •

edited

Loading

vjovanov Sep 21, 2021 •

edited

Loading

filozof50 Sep 24, 2021 •

edited

Loading

filozof50 Sep 30, 2021 •

edited

Loading