[GR-65845] Prevent -H:ExcludeResources=... from excluding directory resources. #11477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When specifying an ExcludeResources pattern that does remove resources files from a resource directory it can happen easily that accidentally the resource-directory gets exuded as well.
Suppose a user adds
-H:ExcludeResources=^resdir/(?!required_res/).*to prevent any resources in resdir that do not match this pattern to get included. Due to having the pattern not only matched against a resourceName but also resourceName + "/" we will accidentally also exclude the "resdir" directory resource. This can break user applications that check for the existence of that directory resource at runtime.