[GR-60297] Fix Reachability Analysis in Native Image #11293
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reuse the registrations and optimizations done before analysis as much as possible
oracle-contributor-agreement
bot
added
the
OCA Verified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes Reachability Analysis available via the
-H:+UseExperimentalReachabilityAnalysisflag.The implementation got out of sync with points-to analysis because it had a separate Graal IR construction pipeline before analysis and its set of registrations was outdated compared to
MethodTypeFlowBuilder.registerUsedElements. To reduce the chances of getting out of sync again, this PR modifies certain parts of reachability analysis to call intoMethodTypeFlowBuilderto reuse its functionality when possible, thus removing code duplication.