Added cli to convert legacy fine tuned model to v2. #1241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lu-ohai
requested review from
darenr,
mayoor,
mrDzurb,
VipulMascarenhas,
qiuosier and
ahosler
as code owners
oracle-contributor-agreement
bot
added
the
OCA Verified
mrDzurb
reviewed
Aug 4, 2025
| or legacy_tags.get(Tags.AQUA_FINE_TUNE_MODEL_VERSION, UNKNOWN).lower() | ||
| == AQUA_FINE_TUNE_MODEL_VERSION | ||
| ): | ||
| raise AquaValueError( |
There was a problem hiding this comment.
raise AquaValueError(
f"Model '{model_id}' is not eligible for conversion. Only legacy AQUA fine-tuned models "
f"without the 'fine_tune_model_version={AQUA_FINE_TUNE_MODEL_VERSION}' tag are supported."
)
| .create(model_by_reference=True) | ||
| ) | ||
|
|
||
| logger.info( |
There was a problem hiding this comment.
f"Successfully created version '{AQUA_FINE_TUNE_MODEL_VERSION}' fine-tuned model: '{fine_tune_model_v2.id}' "
f"based on legacy model '{model_id}'. This model is now ready for deployment."
)```
| ) | ||
|
|
||
| if not legacy_fine_tuned_model.model_file_description: | ||
| raise AquaValueError( |
There was a problem hiding this comment.
raise AquaValueError(
f"Model '{model_id}' is missing required metadata and cannot be converted. "
"This may indicate the model was not created properly or is not a supported legacy AQUA fine-tuned model."
)
| @@ -645,6 +646,80 @@ def edit_registered_model( | |||
| else: | |||
| raise AquaRuntimeError("Only registered unverified models can be edited.") | |||
|
|
|||
| def convert_fine_tune( | |||
There was a problem hiding this comment.
We need to add one more validation, in case if model is already converted to V2, we should inform user about this and say:
logger.info(
f"Model '{model_id}' is already a fine-tuned model in version '{AQUA_FINE_TUNE_MODEL_VERSION}'. "
"No conversion is necessary."
)
There was a problem hiding this comment.
There was a problem hiding this comment.
Let's make it more explicit. I mean for this use case let's show the dedicated message that I've posted above. Otherwise users might think that something wrong with their model.
mrDzurb
approved these changes
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added cli to convert legacy fine tuned model to v2.
convert_fine_tuneto convert legacy fine tuned model to v2.Integration
fine_tune_model_versionand only fine tune artifacts inmodel_file_description.jsonUnit