Removed dependency on lodash.forEach #412
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjc1283
suggested changes
Feb 21, 2020
Contributor
mjc1283
left a comment
mjc1283
left a comment
There was a problem hiding this comment.
LGTM, but please remove filter
fayyazarshad
force-pushed
the
fayyaz/replace_lodash_forEach
branch
from
ec0c077 to
a6fd422
Compare
mjc1283
approved these changes
Feb 24, 2020
mjc1283
suggested changes
Feb 24, 2020
fayyazarshad
force-pushed
the
fayyaz/replace_lodash_forEach
branch
2 times, most recently
from
dd47d8d to
37ff70c
Compare
mjc1283
suggested changes
Feb 25, 2020
mjc1283
approved these changes
Feb 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
to reduce package size, we are trying to gradually get rid of lodash library. This PR removes the implementation of fns.forEach and replaced it with default forEach method of arrays and Object.Keys for maps
Test plan
All tests are passing