Removed dependency on lodash.isEmpty #403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zashraf1985
changed the title
mjc1283
suggested changes
Feb 20, 2020
Contributor
mjc1283
left a comment
mjc1283
left a comment
There was a problem hiding this comment.
@fayyazarshad @zashraf1985 I was looking around at the places where isEmpty is called. It seems like we don't actually need this. I think they could be replaced by a check for a truth-y value.
For example( getExperimentId, packages/optimizely-sdk/lib/core/project_config/index.js) instead of :
var experiment = projectConfig.experimentKeyMap[experimentKey];
if (fns.isEmpty(experiment)) {We can do:
var experiment = projectConfig.experimentKeyMap[experimentKey];
if (!experiment) {
fayyazarshad
force-pushed
the
fayyaz/replace_lodash_isEmpty
branch
from
2be9a53 to
2d1a069
Compare
mjc1283
approved these changes
Feb 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
to reduce package size, we are trying to gradually get rid of lodash library. This PR replaces isEmpty function simple implementation for object. Because we are using this methods for object only
Test plan
Added unit tests for this