fix (umd script test): Default logger calls console.info when logging at info level #218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l instead of console.log
nchilada
approved these changes
Feb 13, 2019
Contributor
nchilada
left a comment
nchilada
left a comment
There was a problem hiding this comment.
Looks good! At some point we might want to reassess the set of tests that we run on the UMD bundle, and maybe integrate that into CI as you've suggested, but this fix looks sufficient for now. 👌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update UMD script test to reflect the latest expected behavior of the default logger (when the level is INFO, it calls
console.info)Test plan
Run UMD script tests (
npm run test-umdbrowser)