[FSSDK-11143] update: Implement CMAB Client #579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…chDecision method and retry logic
…s and error handling
| * @param cmabUuid The CMAB UUID | ||
| * @return CompletableFuture containing the variation ID as a String | ||
| */ | ||
| CompletableFuture<String> fetchDecision(String ruleId, String userId, Map<String, Object> attributes, String cmabUuid); |
There was a problem hiding this comment.
nit: can we rename it as cmabUUID?
| private final int maxRetries; | ||
| private final long backoffBaseMs; | ||
| private final double backoffMultiplier; | ||
|
|
There was a problem hiding this comment.
I think there should a maxTimeout.
| if (attemptNumber < 0) { | ||
| return 0; | ||
| } | ||
| return (long) (backoffBaseMs * Math.pow(backoffMultiplier, attemptNumber)); |
There was a problem hiding this comment.
This logic should be updated with maxTimeOut
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implemented DefaultCmabClient, a client for fetching CMAB (Contextual Multi-Armed Bandit) decisions.
Supports configurable retries with exponential backoff through CmabRetryConfig.
Handles error scenarios such as network failures, non-2xx responses, invalid JSON, and malformed responses.
Logs relevant error and retry information using the Optimizely logger.
Test plan
Issues