Skip to content

fix:Change Log level from WARN to DEBUG for number values in Audience Conditions for revisionNumber #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
The-inside-man wants to merge 3 commits into from
Closed

fix:Change Log level from WARN to DEBUG for number values in Audience Conditions for revisionNumber #459

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
94e48bc
Suggested change for log-level from WARN to DEBUG for number values p…
The-inside-man Jan 20, 2022
d128b7f
Update tests to DEBUG instead of WARN
The-inside-man Jan 21, 2022
5181479
Update log wanrings to debug level in ExperimentUtilsTest.java
The-inside-man Jan 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core-api/src/main/java/com/optimizely/ab/config/audience/UserAttribute.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ public Boolean evaluate(ProjectConfig config, Map<String, ?> attributes) {
}
}
} catch (UnknownMatchTypeException | UnexpectedValueTypeException e) {
logger.warn("Audience condition \"{}\" " + e.getMessage(), this);
logger.debug("Audience condition \"{}\" " + e.getMessage(), this);
} catch (NullPointerException e) {
logger.error("attribute or value null for match {}", match != null ? match : "legacy condition", e);
}
Expand Down
14 changes: 12 additions & 2 deletions ...-api/src/test/java/com/optimizely/ab/config/audience/AudienceConditionEvaluationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
import org.junit.Before;
import org.junit.Rule;
import org.junit.Test;
import org.mockito.internal.matchers.Or;

import java.math.BigInteger;
import java.util.*;
Expand Down Expand Up @@ -165,7 +164,7 @@ public void invalidMatchCondition() throws Exception {
public void invalidMatch() throws Exception {
UserAttribute testInstance = new UserAttribute("browser_type", "custom_attribute", "blah", "chrome");
assertNull(testInstance.evaluate(null, testUserAttributes));
logbackVerifier.expectMessage(Level.WARN,
logbackVerifier.expectMessage(Level.DEBUG,
"Audience condition \"{name='browser_type', type='custom_attribute', match='blah', value='chrome'}\" uses an unknown match type. You may need to upgrade to a newer release of the Optimizely SDK");
}

Expand Down Expand Up @@ -225,6 +224,17 @@ public void unknownConditionType() throws Exception {
"Audience condition \"{name='browser_type', type='blah', match='exists', value='firefox'}\" uses an unknown condition type. You may need to upgrade to a newer release of the Optimizely SDK.");
}

/**
* Verify that UserAttribute.evaluate results of log level of DEBUG for number values passed for revisionNumber
*/
@Test
public void missingConditionType() throws Exception {
UserAttribute testInstance = new UserAttribute("revisionNumber", "custom_attribute", "exact", 17065555);
assertNull(testInstance.evaluate(null, testUserAttributes));
logbackVerifier.expectMessage(Level.DEBUG,
"Audience condition \"{name='revisionNumber', type='custom_attribute', match='exact', value=17065555}\" has an unsupported condition value. You may need to upgrade to a newer release of the Optimizely SDK.");
}

/**
* Verify that UserAttribute.evaluate for EXIST match type returns true for known visitor
* attributes with non-null instances and empty string.
Expand Down
4 changes: 2 additions & 2 deletions core-api/src/test/java/com/optimizely/ab/internal/ExperimentUtilsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ public void doesUserMeetAudienceConditionsHandlesNullValueAttributesWithNull() {

logbackVerifier.expectMessage(Level.DEBUG,
"Starting to evaluate audience \"2196265320\" with conditions: [and, [or, [or, {name='nationality', type='custom_attribute', match='null', value='English'}, {name='nationality', type='custom_attribute', match='null', value=null}]]].");
logbackVerifier.expectMessage(Level.WARN,
logbackVerifier.expectMessage(Level.DEBUG,
"Audience condition \"{name='nationality', type='custom_attribute', match='null', value=null}\" has an unsupported condition value. You may need to upgrade to a newer release of the Optimizely SDK.");
logbackVerifier.expectMessage(Level.DEBUG,
"Audience \"2196265320\" evaluated to null.");
Expand All @@ -283,7 +283,7 @@ public void doesUserMeetAudienceConditionsHandlesNullConditionValue() {

logbackVerifier.expectMessage(Level.DEBUG,
"Starting to evaluate audience \"2196265320\" with conditions: [and, [or, [or, {name='nationality', type='custom_attribute', match='null', value='English'}, {name='nationality', type='custom_attribute', match='null', value=null}]]].");
logbackVerifier.expectMessage(Level.WARN,
logbackVerifier.expectMessage(Level.DEBUG,
"Audience condition \"{name='nationality', type='custom_attribute', match='null', value=null}\" has an unsupported condition value. You may need to upgrade to a newer release of the Optimizely SDK.");
logbackVerifier.expectMessage(Level.DEBUG,
"Audience \"2196265320\" evaluated to null.");
Expand Down