Skip to content

Conversation

@oakbani
Copy link
Contributor

@oakbani oakbani commented Jul 29, 2020

Summary

Stages run sequentially on Travis. If a stage fails, all the following stages are not executed. We execute source clear only on cron, and if due to any reason unit or integration tests fail, the source clear is not executed. Hence, moving source clear stage before tests.

Test plan

All unit tests must be passed.
FSC must be passed.

@oakbani oakbani requested a review from a team as a code owner July 29, 2020 11:10
@oakbani oakbani removed their assignment Jul 29, 2020
@coveralls
Copy link

coveralls commented Jul 29, 2020

Pull Request Test Coverage Report for Build 1471

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.419%

Totals Coverage Status
Change from base Build 1469: 0.0%
Covered Lines: 3955
Relevant Lines: 4423

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1471

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.419%

Totals Coverage Status
Change from base Build 1469: 0.0%
Covered Lines: 3955
Relevant Lines: 4423

💛 - Coveralls

Copy link
Contributor

@msohailhussain msohailhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aliabbasrizvi aliabbasrizvi merged commit 12aceba into master Jul 29, 2020
@aliabbasrizvi aliabbasrizvi deleted the oakbani-patch-1 branch July 29, 2020 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants