Skip to content

Conversation

@gcampfield
Copy link
Contributor

Summary

The Logger name for AudienceIdCondition.java is currently just the static string "AudienceIdCondition". This means that it's not possible to change the log level of this class using the com.optimizely group.

This should be changed to use the class AudienceIdCondition.class itself.

@coveralls
Copy link

coveralls commented Jan 15, 2020

Pull Request Test Coverage Report for Build 1339

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.278%

Totals Coverage Status
Change from base Build 1337: 0.0%
Covered Lines: 3747
Relevant Lines: 4197

💛 - Coveralls

@gcampfield gcampfield changed the title Properly set logger name for AudienceIdCondition Properly set logger name for AudienceIdCondition and ConditionUtils Jan 15, 2020
@mjc1283
Copy link

mjc1283 commented Jan 27, 2020

Hi @gcampfield,

Thanks for submitting this fix. Would you please sign our CLA as described here: https://github.com/optimizely/java-sdk/blob/master/CONTRIBUTING.md#contributing-to-the-optimizely-java-sdk? After that, we are happy to merge this PR.

@gcampfield
Copy link
Contributor Author

I've signed the CLA. Thanks, @mjc1283 !

@mjc1283 mjc1283 merged commit 4b41295 into optimizely:master Jan 27, 2020
@gcampfield gcampfield deleted the patch-1 branch January 27, 2020 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants