Skip to content

(chore): chrerry pick changes to 3.3.x. #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomaszurkan-optimizely merged 2 commits into from
Oct 11, 2019
Merged

(chore): chrerry pick changes to 3.3.x. #342

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ffcd14f
(fix): use a ParserSupplier instead of java.util.Supplier to enable w…
thomaszurkan-optimizely Oct 11, 2019
642d024
update for new release for android support (#341)
thomaszurkan-optimizely Oct 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Optimizely Java X SDK Changelog

## 3.3.1
October 11th, 2019

### New Features:
- java.util.Supplier is not supported below Android API 24. In order to support Android 22 which still has more than 10% market share, we have changed our implementation to use our own config supplier interface.

## 3.3.0
October 1st, 2019

Expand Down
14 changes: 12 additions & 2 deletions core-api/src/main/java/com/optimizely/ab/config/parser/DefaultConfigParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,16 @@ public static ConfigParser getInstance() {
}

//======== Helper methods ========//
@FunctionalInterface
public interface ParserSupplier {

/**
* Gets a result.
*
* @return a result
*/
ConfigParser get();
}

public enum ConfigParserSupplier {
// WARNING THESE MUST REMAIN LAMBDAS!!!
Expand All @@ -49,9 +59,9 @@ public enum ConfigParserSupplier {
JSON_SIMPLE_CONFIG_PARSER("org.json.simple.JSONObject", () -> { return new JsonSimpleConfigParser(); });

private final String className;
private final Supplier<ConfigParser> supplier;
private final ParserSupplier supplier;

ConfigParserSupplier(String className, Supplier<ConfigParser> supplier) {
ConfigParserSupplier(String className, ParserSupplier supplier) {
this.className = className;
this.supplier = supplier;
}
Expand Down