Skip to content

chore(release): Preparing for 3.1.0 release #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aliabbasrizvi merged 3 commits into from
May 6, 2019
Merged

chore(release): Preparing for 3.1.0 release #294

aliabbasrizvi merged 3 commits into from
May 6, 2019

Conversation

@aliabbasrizvi
Copy link
Contributor

@aliabbasrizvi aliabbasrizvi commented May 3, 2019

No description provided.

@aliabbasrizvi aliabbasrizvi changed the base branch from master to 3.1.x May 3, 2019 23:23
@aliabbasrizvi aliabbasrizvi changed the base branch from 3.1.x to master May 3, 2019 23:23
@aliabbasrizvi aliabbasrizvi requested a review from mikeproeng37 May 3, 2019 23:23
@coveralls
Copy link

coveralls commented May 4, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 1026

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.068%
Totals Coverage Status
Change from base Build 1025: 0.0%
Covered Lines: 3088
Relevant Lines: 3467
💛 - Coveralls

mikeproeng37
mikeproeng37 approved these changes May 6, 2019
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@aliabbasrizvi aliabbasrizvi force-pushed the ali/prepare_for_release branch from 02e1518 to 2af0f33 Compare May 6, 2019 20:08
mikecdavis
mikecdavis approved these changes May 6, 2019
View reviewed changes
Copy link
Contributor

@mikecdavis mikecdavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aliabbasrizvi aliabbasrizvi merged commit 7f72b0a into master May 6, 2019
@aliabbasrizvi aliabbasrizvi deleted the ali/prepare_for_release branch May 6, 2019 23:22
aliabbasrizvi added a commit that referenced this pull request May 6, 2019
@aliabbasrizvi
chore(release): Preparing for 3.1.0 release (#294)
d78800f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

@mikecdavis mikecdavis mikecdavis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@aliabbasrizvi @coveralls @mikeproeng37 @mikecdavis