Skip to content

Feat: Updated Activate/Variation notification listener implementation as per new design #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aliabbasrizvi merged 3 commits into from
Apr 17, 2019
Merged

Feat: Updated Activate/Variation notification listener implementation as per new design #282

aliabbasrizvi merged 3 commits into from
Apr 17, 2019

Conversation

@mnoman09
Copy link
Contributor

@mnoman09 mnoman09 commented Apr 17, 2019

Summary

  • Added source_info in decision info object of decision listener
  • Changed DecisionSource experiment to feature-test
  • Added one more DecisionNotificationType of feature-test
  • Changed DecisionNotificatonType.Experiment to DecisionNotificatonType.AB_TEST and DecisionSource.Experiment to DecisionSource.Feature-test

Ticket

@mnoman09 mnoman09 requested a review from aliabbasrizvi April 17, 2019 15:30
aliabbasrizvi
aliabbasrizvi approved these changes Apr 17, 2019
View reviewed changes
Copy link
Contributor

@aliabbasrizvi aliabbasrizvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

core-api/src/main/java/com/optimizely/ab/notification/NotificationCenter.java Outdated
EXPERIMENT("experiment");
FEATURE_TEST("feature-test"),
FEATURE_VARIABLE("feature-variable"),
AB_TEST("ab-test");
Copy link
Contributor

@aliabbasrizvi aliabbasrizvi Apr 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit. alphabetize.

@mnoman09 mnoman09 requested a review from aliabbasrizvi April 17, 2019 17:01
@aliabbasrizvi aliabbasrizvi merged commit 511c6e9 into mnoman/ActivateVarNewListener Apr 17, 2019
@aliabbasrizvi aliabbasrizvi deleted the mnoman/activateListenerChanges branch April 17, 2019 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@aliabbasrizvi aliabbasrizvi aliabbasrizvi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mnoman09 @aliabbasrizvi