Skip to content

Conversation

@mnoman09
Copy link
Contributor

@mnoman09 mnoman09 commented Feb 7, 2019

Summary

  • Refactored code and changed liveVariable to FeatureVariable and removed it from json
  • Removed extra classes which were used by liveVariables
  • Refactored ProjectConfig and removed passing of liveVariables

@coveralls
Copy link

coveralls commented Feb 7, 2019

Pull Request Test Coverage Report for Build 873

  • 73 of 77 (94.81%) changed or added relevant lines in 9 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.5%) to 89.038%

Changes Missing Coverage Covered Lines Changed/Added Lines %
core-api/src/main/java/com/optimizely/ab/config/FeatureFlag.java 4 5 80.0%
core-api/src/main/java/com/optimizely/ab/config/FeatureVariable.java 2 3 66.67%
core-api/src/main/java/com/optimizely/ab/config/FeatureVariableUsageInstance.java 1 2 50.0%
core-api/src/main/java/com/optimizely/ab/config/parser/JsonConfigParser.java 23 24 95.83%
Files with Coverage Reduction New Missed Lines %
core-api/src/main/java/com/optimizely/ab/config/parser/JacksonHelpers.java 1 77.78%
Totals Coverage Status
Change from base Build 872: -0.5%
Covered Lines: 2648
Relevant Lines: 2974

💛 - Coveralls

Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@thomaszurkan-optimizely thomaszurkan-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomaszurkan-optimizely thomaszurkan-optimizely merged commit 7ac2b72 into master Feb 11, 2019
@mnoman09 mnoman09 deleted the mnoman/removedLiveVarFunc branch March 5, 2019 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants