Skip to content

Conversation

@mnoman09
Copy link
Contributor

@mnoman09 mnoman09 commented Dec 6, 2018

Summary

  • Checked LogEvent request method type if it is get than generate get request and if it is post than generate post request.

Issues

  • failure asserting results[reach][total_count] == expectation.total_impressions
    ERROR:root:expected 1 total visitors; actually found 0 total visitors

Copy link
Contributor

@thomaszurkan-optimizely thomaszurkan-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomaszurkan-optimizely thomaszurkan-optimizely merged commit 1ed7694 into master Dec 6, 2018
@thomaszurkan-optimizely thomaszurkan-optimizely deleted the mnoman/fixingPostImpIssue branch December 6, 2018 18:46
@coveralls
Copy link

coveralls commented Dec 8, 2018

Pull Request Test Coverage Report for Build 783

  • 2 of 12 (16.67%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 89.77%

Changes Missing Coverage Covered Lines Changed/Added Lines %
core-httpclient-impl/src/main/java/com/optimizely/ab/event/AsyncEventHandler.java 2 12 16.67%
Totals Coverage Status
Change from base Build 779: -0.1%
Covered Lines: 2694
Relevant Lines: 3001

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants