Skip to content

Conversation

@thomaszurkan-optimizely
Copy link
Contributor

Summary

  • After adding some compatibility tests, we discovered there were some errors in single leaf processing. Fixed those and added tests.

Test plan

Added unit tests in all json parsers for single leaf parsing.
Added a single leaf node in the datafile and have all parsers parse it the same.

Issues

  • Java SDK was failing compatibility tests.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 766

  • 17 of 18 (94.44%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 89.86%

Changes Missing Coverage Covered Lines Changed/Added Lines %
core-api/src/main/java/com/optimizely/ab/config/parser/ConditionJacksonDeserializer.java 16 17 94.12%
Totals Coverage Status
Change from base Build 765: 0.1%
Covered Lines: 2694
Relevant Lines: 2998

💛 - Coveralls

@coveralls
Copy link

coveralls commented Nov 21, 2018

Pull Request Test Coverage Report for Build 769

  • 15 of 16 (93.75%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 89.947%

Changes Missing Coverage Covered Lines Changed/Added Lines %
core-api/src/main/java/com/optimizely/ab/config/parser/ConditionJacksonDeserializer.java 13 14 92.86%
Totals Coverage Status
Change from base Build 765: 0.2%
Covered Lines: 2693
Relevant Lines: 2994

💛 - Coveralls

Copy link
Contributor

@nchilada nchilada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So fast! Thanks! Might be good to run the compatibility test against this if you know how (I don't 😬)

@thomaszurkan-optimizely thomaszurkan-optimizely merged commit 1821874 into master Nov 24, 2018
@thomaszurkan-optimizely thomaszurkan-optimizely deleted the leafNodeFixes branch November 24, 2018 02:16
@nchilada
Copy link
Contributor

The compat test now passes! Thanks @thomaszurkan-optimizely 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants