fix(datafile-parsing): Prevent SDK from initializing if the datafile … #205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 15, 2018 15:56
…version is higher than the max version supported.
mikeproeng37
requested review from
aliabbasrizvi,
shihpatrick and
thomaszurkan-optimizely
Pull Request Test Coverage Report for Build 579
💛 - Coveralls |
thomaszurkan-optimizely
approved these changes
Aug 16, 2018
Contributor
thomaszurkan-optimizely
left a comment
thomaszurkan-optimizely
left a comment
There was a problem hiding this comment.
I'm approving but I had one question/concern about locking us out of future datafile versions.
| "Please use a version 2 or 3 datafile with this SDK."); | ||
| } | ||
|
|
||
| if (Integer.parseInt(projectConfig.getVersion()) > Integer.parseInt(Version.V4.version)) { |
Contributor
There was a problem hiding this comment.
is this necessary?
aliabbasrizvi
suggested changes
Aug 16, 2018
| } | ||
|
|
||
| /** | ||
| * @return a {@link ProjectConfig} instance given a json string datafile |
| if (datafile == null) { | ||
| throw new ConfigParseException("Unable to parse null datafile."); | ||
| } | ||
| if (datafile.length() == 0) { |
Contributor
There was a problem hiding this comment.
Why not use isEmpty?
| "Please use a version 2 or 3 datafile with this SDK."); | ||
| } | ||
|
|
||
| if (Integer.parseInt(projectConfig.getVersion()) > Integer.parseInt(Version.V4.version)) { |
Contributor
There was a problem hiding this comment.
I wouldn't rely on datafile version being integer.
Contributor
There was a problem hiding this comment.
Rather just create a list of supported and unsupported datafile versions.
aliabbasrizvi
approved these changes
Aug 17, 2018
Contributor
aliabbasrizvi
left a comment
aliabbasrizvi
left a comment
There was a problem hiding this comment.
Please address comments before merging.
| import com.optimizely.ab.error.NoOpErrorHandler; | ||
| import com.optimizely.ab.error.RaiseExceptionErrorHandler; | ||
| import com.optimizely.ab.internal.ControlAttribute; | ||
| import com.optimizely.ab.config.parser.DefaultConfigParser; |
| } | ||
|
|
||
| private static final List<String> supportedVersions = Arrays.asList( | ||
| Version.V2.version, |
Contributor
There was a problem hiding this comment.
nit. Indentation seems off. I think we have 4 spaces going on.
| } | ||
|
|
||
| @Test | ||
| public void withInvalidNewerDatafile() throws Exception { |
Contributor
There was a problem hiding this comment.
nit. We can just say withInvalidDatafile or better withUnsupportedDatafile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a
Builderclass for theProjectConfigentity and moves construction of it out of the mainOptimizelyclass.Adds a check to ensure that we cannot initialize the
ProjectConfigwith newer datafile versions.https://optimizely.atlassian.net/browse/OASIS-3464