Skip to content

Conversation

@mikeproeng37
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Apr 12, 2018

Pull Request Test Coverage Report for Build 507

  • 0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 88.784%

Totals Coverage Status
Change from base Build 505: 0.0%
Covered Lines: 2161
Relevant Lines: 2434

💛 - Coveralls

optimizelyClient.track("event_key", "user_id", userAttributes, eventTags);
```

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add the following to Breaking Changes?:

We have removed deprecated classes with the NotificationBroadcaster in favor of the new API with the NotificationCenter. We have streamlined the API so that it is easily usable with Java Lambdas in Java 1.8+. We have also added some convenience methods to add these listeners. Finally, some of the API names have changed slightly (e.g. clearAllNotifications() is now clearAllNotificationListeners())

Copy link
Contributor

@thomaszurkan-optimizely thomaszurkan-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the notification listener changes to 'Breaking Changes'

Copy link
Contributor

@thomaszurkan-optimizely thomaszurkan-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikeproeng37 mikeproeng37 merged commit 74b1cc6 into master Apr 12, 2018
@mikeproeng37 mikeproeng37 deleted the mng/bump-2.0 branch January 15, 2019 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants