[FSSDK-11544] Parsing holdout configuration from datafile + project config holdout impl. #384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junaed-optimizely
changed the title
There was a problem hiding this comment.
Pull Request Overview
Implements holdout functionality for the Optimizely SDK by adding datafile parsing support and project configuration integration. This enables holdout experiments that can be applied globally or targeted to specific feature flags.
- Added comprehensive holdout entity model with flag inclusion/exclusion logic
- Introduced holdout configuration manager for efficient flag-to-holdout relationship mapping
- Extended project configuration interface to support holdout operations and queries
Reviewed Changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| OptimizelySDK/Utils/HoldoutConfig.cs | Core holdout configuration manager with caching and flag relationship logic |
| OptimizelySDK/Entity/Holdout.cs | Complete holdout entity implementation with audience and variation support |
| OptimizelySDK/Entity/IExperimentCore.cs | Shared interface for common experiment/holdout functionality |
| OptimizelySDK/Entity/ExperimentCoreExtensions.cs | Extension methods for shared experiment/holdout operations |
| OptimizelySDK/Entity/Experiment.cs | Updated to implement IExperimentCore interface |
| OptimizelySDK/ProjectConfig.cs | Added holdout-related interface methods |
| OptimizelySDK/Config/DatafileProjectConfig.cs | Integrated holdout parsing and configuration management |
| Various project files | Added new entity and utility files to compilation |
| Test files | Comprehensive test coverage for holdout functionality |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
muzahidul-opti
requested changes
Aug 14, 2025
mikechu-optimizely
approved these changes
Aug 14, 2025
muzahidul-opti
approved these changes
Aug 20, 2025
junaed-optimizely
deleted the
junaed/fssdk-11544-parsing-the-holdout-from-datafile
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Datafile Parsing to support holdout + ProjectConfig holdout change
Test plan
Tests have been added to support the changes
Issues
FSSDK-11544
FSSDK-11545