Skip to content

Update OLM version to 0.24.0 #6362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 17, 2023
Merged

Update OLM version to 0.24.0 #6362

merged 1 commit into from
Mar 17, 2023

Conversation

@oceanc80
Copy link
Collaborator

@oceanc80 oceanc80 commented Mar 15, 2023

Description of the change:
Updates OLM version in places missed by make bindata target.

Motivation for the change:

Checklist

If the pull request includes user-facing changes, extra documentation is required:

@oceanc80
Update OLM version to 0.24.0
5f468d3 
Signed-off-by: Catherine Chan-Tse <[email protected]>
@openshift-ci openshift-ci bot requested review from anik120 and joelanford March 15, 2023 19:19
@oceanc80 oceanc80 temporarily deployed to deploy March 15, 2023 19:20 — with GitHub Actions Inactive
@oceanc80 oceanc80 temporarily deployed to deploy March 15, 2023 19:20 — with GitHub Actions Inactive
@oceanc80 oceanc80 temporarily deployed to deploy March 15, 2023 19:20 — with GitHub Actions Inactive
@oceanc80 oceanc80 temporarily deployed to deploy March 15, 2023 19:20 — with GitHub Actions Inactive
@oceanc80 oceanc80 temporarily deployed to deploy March 15, 2023 19:20 — with GitHub Actions Inactive
@oceanc80 oceanc80 temporarily deployed to deploy March 15, 2023 19:20 — with GitHub Actions Inactive
@oceanc80 oceanc80 temporarily deployed to deploy March 15, 2023 19:20 — with GitHub Actions Inactive
@oceanc80 oceanc80 temporarily deployed to deploy March 15, 2023 19:20 — with GitHub Actions Inactive
@oceanc80 oceanc80 temporarily deployed to deploy March 15, 2023 19:20 — with GitHub Actions Inactive
varshaprasad96
varshaprasad96 requested changes Mar 15, 2023
View reviewed changes
Copy link
Member

@varshaprasad96 varshaprasad96 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oceanc80 We need to update the docs and the e2e test to use the updated OLM version.

@oceanc80
Copy link
Collaborator Author

oceanc80 commented Mar 15, 2023 •
edited
Loading

@varshaprasad96 The docs and e2e test were updated in these PRs: #6360 and #6359
I forgot that the make bindata command misses some files so I didn't manually fix them the first go round and needed this follow-up PR.

@varshaprasad96
Copy link
Member

varshaprasad96 commented Mar 16, 2023

@oceanc80 Ah, I see. Sorry missed it!

The e2e in master still uses to 0.23.1 though (

operator-sdk/internal/testutils/olm.go

Line 29 in 484013d

OlmVersionForTestSuite = "0.23.1"
).

everettraven
everettraven approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 16, 2023
rashmigottipati
rashmigottipati approved these changes Mar 16, 2023
View reviewed changes
Copy link
Member

@rashmigottipati rashmigottipati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

varshaprasad96
varshaprasad96 approved these changes Mar 16, 2023
View reviewed changes
Copy link
Member

@varshaprasad96 varshaprasad96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@oceanc80 oceanc80 merged commit 411623e into operator-framework:master Mar 17, 2023
@oceanc80 oceanc80 deleted the update-bindata branch March 17, 2023 19:39
@oceanc80
Copy link
Collaborator Author

oceanc80 commented Mar 17, 2023

/cherry-pick v1.28.x

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 17, 2023
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Mar 17, 2023

@oceanc80: new pull request created: #6367

In response to this:

/cherry-pick v1.28.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rashmigottipati rashmigottipati rashmigottipati approved these changes

@everettraven everettraven everettraven approved these changes

@varshaprasad96 varshaprasad96 varshaprasad96 approved these changes

@anik120 anik120 Awaiting requested review from anik120

@joelanford joelanford Awaiting requested review from joelanford

Assignees

@rashmigottipati rashmigottipati

@everettraven everettraven

@varshaprasad96 varshaprasad96

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@oceanc80 @varshaprasad96 @openshift-cherrypick-robot @rashmigottipati @everettraven