Rename golang occurrences to go #4614
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmrodri
requested review from
jmrodri and
marc-obrien
and removed request for
fabianvf and
jmccormick2001
estroz
approved these changes
Mar 9, 2021
Member
estroz
left a comment
estroz
left a comment
There was a problem hiding this comment.
@dastergon thanks! You can also update website/content/en/docs/building-operators/golang/ to website/content/en/docs/building-operators/go/ if you'd like.
/lgtm
Contributor
Author
|
@estroz That change might break URLs that's why I didn't include it in the changes. If you believe that's OK, I can send an extra commit updating the URL. |
Member
|
@dastergon fair enough, that can be done later. Can you add a DCO to your commit? Then I'll approve and merge. |
Signed-off-by: Pavlos Ratis <[email protected]>
|
New changes are detected. LGTM label has been removed. |
Contributor
Author
|
@estroz added a DCO to the commit. I hope it's fine now. |
Member
|
/retest |
reinvantveer
pushed a commit
to reinvantveer/operator-sdk
that referenced
this pull request
Mar 11, 2021
Signed-off-by: Pavlos Ratis <[email protected]>
reinvantveer
pushed a commit
to reinvantveer/operator-sdk
that referenced
this pull request
Mar 11, 2021
Signed-off-by: Pavlos Ratis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
This PR renames most of the
Golangoccurrences toGo. The only exception are the proposals, which, are historical archives, so, I believe that there's no need for a change.Motivation for the change:
The main motivation is to keep consistency with the naming across the project. Some sections mention Go and others Golang. Also, according to the official website,
Gois the proper name to use.Checklist
website/content/en/docs