Skip to content

Conversation

@estroz
Copy link
Member

@estroz estroz commented Feb 15, 2021

This reverts commit 4c0a60d.

#4494 was merged prematurely. Builds for s390x, ppc64le, arm64 are broken due to gcc (and other deps) not being installed, but during some testing I also discovered that the Pipfile.lock's hashes don't resolve on s390x builds (at least) and I can't debug the issue. #4494 should be reverted until builds on all platforms can be tested using Github Actions for each PR, since we're moving away from Travis completely soon. This is something I'm working on right now using docker buildx.

This reverts commit 4c0a60d.

Signed-off-by: Eric Stroczynski <[email protected]>
@estroz
Copy link
Member Author

estroz commented Feb 15, 2021

/cc @reinvantveer

@openshift-ci-robot
Copy link

@estroz: GitHub didn't allow me to request PR reviews from the following users: reinvantveer.

Note that only operator-framework members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @reinvantveer

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 15, 2021
@estroz estroz merged commit 55b97d9 into operator-framework:master Feb 15, 2021
@estroz estroz deleted the revert/4494 branch February 15, 2021 23:43
@reinvantveer
Copy link
Contributor

Yikes!

@joelanford
Copy link
Member

@estroz This github actions workflow may be of interest to you:

https://github.com/joelanford/helm-operator/blob/main/.github/workflows/deploy.yml

It runs the goreleaser and docker builds on all PRs, but only publishes on tags.

@reinvantveer
Copy link
Contributor

I can see pipenv retrying a couple of times on some hashes, but so far I can see builds failing only on missing gcc. So perhaps if we install and de-install gcc as a build dependency for the python dependency phase, things will be OK?

reinvantveer added a commit to reinvantveer/operator-sdk that referenced this pull request Feb 16, 2021
@estroz
Copy link
Member Author

estroz commented Feb 16, 2021

So perhaps if we install and de-install gcc as a build dependency for the python dependency phase, things will be OK?

It doesn't appear to be the only issue. After adding gcc (along with redhat-lsb-core) and trying to build with docker buildx build -f ./images/ansible-operator/Dockerfile --platform linux/s390x ./images/ansible-operator you see other errors on pipenv install --deploy.

@reinvantveer
Copy link
Contributor

OK I' ll give it a try

@reinvantveer
Copy link
Contributor

#4543 is where I intend to get things going again, if possible

reinvantveer added a commit to reinvantveer/operator-sdk that referenced this pull request Feb 28, 2021
reinvantveer added a commit to reinvantveer/operator-sdk that referenced this pull request Mar 5, 2021
reinvantveer added a commit to reinvantveer/operator-sdk that referenced this pull request Mar 7, 2021
reinvantveer added a commit to reinvantveer/operator-sdk that referenced this pull request Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants