Skip to content

cleanup: call install in the sample target #4057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

cleanup: call install in the sample target #4057

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ generate: cli-doc samples bindata ## Run all non-release generate targets
cli-doc: ## Generate CLI documentation
go run ./hack/generate/cli-doc/gen-cli-doc.go

samples: ## Generate samples
samples: install ## Generate samples
go run ./hack/generate/samples/generate_all.go

changelog: ## Generate CHANGELOG.md and migration guide updates
Expand Down
1 change: 0 additions & 1 deletion hack/tests/sanity-check.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ go fmt ./...
make cli-doc
go run ./hack/generate/changelog/gen-changelog.go -validate-only

make install
make samples

# Make sure repo is still in a clean state.
Expand Down