cleanup: call install in the sample target #4057
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe this is already resolved in #4023. I’d prefer we capture all Makefile related changes there to avoid competing PRs and rebases. |
|
Hi @joelanford, This PR is very specific to address the action to instead of calling the make install in the sanity add it to the samples target in order to make it easier for contributors since they can face issues just because forgot to run make install before to re-gen the samples. So, I do not see any problem to not get it merged. However, I am fine to do that in #4023 . Btw it is NOT done in the #4023 |
Can you explain what's missing? |
|
closing it in favor of #4023 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Motivation for the change: