internal/generate/crd: fix flaky unit test #2410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strings containing numbers starting with 0 that contain non-octal digits, ex. "012345678". This commit fixes a flakey unit test that occasionally triggers this bug. A more thorough fix will be implemented in the near future. internal/generate/crd: fix controller-gen octal string bug
estroz
requested review from
jmrodri,
joelanford,
hasbro17,
theishshah and
camilamacedo86
openshift-ci-robot
added
the
size/S
jmccormick2001
approved these changes
Jan 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Motivation for the change: controller-gen's output rule for CRD generation disallows directory strings containing numbers starting with 0 that contain non-octal digits, ex. "012345678". This commit fixes a flaky unit test that occasionally triggers this bug. A more thorough fix will be implemented in the near future.