Skip to content

Fix type of node in the test-framework data according to API rule validations #2130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2019
Merged

Fix type of node in the test-framework data according to API rule validations #2130

merged 1 commit into from
Nov 4, 2019

Conversation

camilamacedo86
Copy link
Contributor

@camilamacedo86 camilamacedo86 commented Oct 30, 2019 •
edited
Loading

Description of the change:

  • Fix type of node in the test-framework data according to API rule validations

Motivation for the change:

Related to: #2114 and #2042

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 30, 2019
@camilamacedo86 camilamacedo86 changed the title fix memcached type Fix type of node in the test-framework data according to API rule validations Oct 30, 2019
@camilamacedo86 camilamacedo86 mentioned this pull request Oct 30, 2019
Merged
This was referenced Oct 31, 2019
Merged
Merged
@camilamacedo86
Copy link
Contributor Author

So, @joelanford

The // comment was removed. Can we merge this one in order to move forward with the others?

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 1, 2019
@camilamacedo86 camilamacedo86 removed the request for review from shawn-hurley November 1, 2019 14:47
@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 1, 2019
@camilamacedo86
Copy link
Contributor Author

Hi @joelanford,

All done. Let's merge this one? WDYT?

@camilamacedo86 camilamacedo86 mentioned this pull request Nov 1, 2019
Merged
joelanford
joelanford approved these changes Nov 4, 2019
View reviewed changes
Copy link
Member

@joelanford joelanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2019
@camilamacedo86 camilamacedo86 merged commit c0335ab into operator-framework:master Nov 4, 2019
@camilamacedo86 camilamacedo86 deleted the test-framework-type-fix branch November 4, 2019 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelanford joelanford joelanford approved these changes

@hasbro17 hasbro17 Awaiting requested review from hasbro17

@jmrodri jmrodri Awaiting requested review from jmrodri

@jmccormick2001 jmccormick2001 Awaiting requested review from jmccormick2001

@estroz estroz Awaiting requested review from estroz

@asmacdo asmacdo Awaiting requested review from asmacdo

Assignees

@joelanford joelanford

Labels
lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@camilamacedo86 @joelanford @openshift-ci-robot