Skip to content
This repository was archived by the owner on Nov 18, 2020. It is now read-only.

upgrade to use sdk v0.11.0 #82

Merged
merged 1 commit into from
Nov 12, 2019
Merged

upgrade to use sdk v0.11.0 #82

merged 1 commit into from
Nov 12, 2019

Conversation

camilamacedo86
Copy link
Contributor

@camilamacedo86 camilamacedo86 commented Oct 24, 2019 •
edited
Loading

Description

  • Upgrade the project to use SDK 0.11
  • Fix CSV file

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 24, 2019
@camilamacedo86 camilamacedo86 changed the title WIP : upgrade to use sdk v0.11.0 upgrade to use sdk v0.11.0 Oct 24, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 24, 2019
@camilamacedo86 camilamacedo86 mentioned this pull request Oct 24, 2019
Closed
joelanford
joelanford reviewed Oct 25, 2019
View reviewed changes
Copy link
Member

@joelanford joelanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Main question is about the new nodes.names nesting. Otherwise looks good.

@joelanford joelanford mentioned this pull request Oct 25, 2019
Merged
@camilamacedo86
Copy link
Contributor Author

Hi @joelanford,

So, confirmed with the k8s maintainers the []string is no longer acceptable and the reverted the change in the gitignore. So, let me know if you are ok with and if we can merge this one?

@camilamacedo86
Copy link
Contributor Author

Hi @joelanford,

I think that all are addressed here. Could you please let us know if you are ok with now and if we can merge this one?

joelanford
joelanford suggested changes Oct 31, 2019
View reviewed changes
Copy link
Member

@joelanford joelanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few fixes, and I'd like Eric's input about the CSV versioning question.

@openshift-ci-robot openshift-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 31, 2019
@camilamacedo86
Copy link
Contributor Author

Hi @joelanford and @estroz,

Feel free to check it now. All done.
After this PR we need to upgrade it to 0.12.0 :-)

estroz
estroz reviewed Nov 4, 2019
View reviewed changes
Copy link
Member

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

pending approval of the package manifest format.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2019
@camilamacedo86 camilamacedo86 requested a review from estroz November 5, 2019 21:24
@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 6, 2019
joelanford
joelanford approved these changes Nov 12, 2019
View reviewed changes
Copy link
Member

@joelanford joelanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@camilamacedo86 camilamacedo86 merged commit 3db96ba into operator-framework:master Nov 12, 2019
@camilamacedo86 camilamacedo86 deleted the upgrade-go-11 branch November 12, 2019 18:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joelanford joelanford joelanford approved these changes

@estroz estroz estroz approved these changes

@jmrodri jmrodri Awaiting requested review from jmrodri

@AlexNPavel AlexNPavel Awaiting requested review from AlexNPavel

@asmacdo asmacdo Awaiting requested review from asmacdo

@fabianvf fabianvf Awaiting requested review from fabianvf

@jmccormick2001 jmccormick2001 Awaiting requested review from jmccormick2001

@hasbro17 hasbro17 Awaiting requested review from hasbro17

Assignees

@estroz estroz

Labels
size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@camilamacedo86 @openshift-ci-robot @joelanford @estroz