Skip to content

feat(olm-catalog) : add missing fields with placehoders in the CSV #2095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

feat(olm-catalog) : add missing fields with placehoders in the CSV #2095

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fab84f8
add warn for spec.icon in olm-catalog command
camilamacedo86 Oct 28, 2019
004d835
add info in the docs
camilamacedo86 Oct 31, 2019
f3c442a
Update doc/user/olm-catalog/generating-a-csv.md
camilamacedo86 Oct 31, 2019
b4beede
Update CHANGELOG.md
camilamacedo86 Nov 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

- Added `Operator Version: X.Y.Z` information in the operator logs.([#1953](https://github.com/operator-framework/operator-sdk/pull/1953))
- Make Ansible verbosity configurable via the `ansible-verbosity` flag. ([#2087](https://github.com/operator-framework/operator-sdk/pull/2087))
- Added warn for spec.icon OLM field when the CSV file is generated. ([#2095](https://github.com/operator-framework/operator-sdk/pull/2095))

### Changed

Expand Down
3 changes: 3 additions & 0 deletions internal/scaffold/olm-catalog/csv.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,6 +272,9 @@ func getEmptyRequiredCSVFields(csv *olmapiv1alpha1.ClusterServiceVersion) (field
if csv.Spec.Maturity == "" {
fields = append(fields, "spec.maturity")
}
if len(csv.Spec.Icon) == 0 {
fields = append(fields, "spec.icon")
}

return fields
}
Expand Down