Skip to content

WIP: 🌱 remove no longer required grpc replace (issue: #3284) #3529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 7 additions & 11 deletions go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ require (
golang.org/x/net v0.41.0
golang.org/x/sync v0.15.0
golang.org/x/time v0.12.0
google.golang.org/grpc v1.72.1
google.golang.org/grpc v1.73.0
gopkg.in/yaml.v2 v2.4.0
k8s.io/api v0.32.3
k8s.io/apiextensions-apiserver v0.32.3
Expand Down Expand Up @@ -149,12 +149,12 @@ require (
go.opentelemetry.io/auto/sdk v1.1.0 // indirect
go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.53.0 // indirect
go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.59.0 // indirect
go.opentelemetry.io/otel v1.34.0 // indirect
go.opentelemetry.io/otel v1.35.0 // indirect
go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.33.0 // indirect
go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.32.0 // indirect
go.opentelemetry.io/otel/metric v1.34.0 // indirect
go.opentelemetry.io/otel/sdk v1.34.0 // indirect
go.opentelemetry.io/otel/trace v1.34.0 // indirect
go.opentelemetry.io/otel/metric v1.35.0 // indirect
go.opentelemetry.io/otel/sdk v1.35.0 // indirect
go.opentelemetry.io/otel/trace v1.35.0 // indirect
go.opentelemetry.io/proto/otlp v1.4.0 // indirect
go.uber.org/automaxprocs v1.6.0 // indirect
go.uber.org/multierr v1.11.0 // indirect
Expand All @@ -169,8 +169,8 @@ require (
golang.org/x/tools v0.33.0 // indirect
gomodules.xyz/jsonpatch/v2 v2.4.0 // indirect
google.golang.org/genproto v0.0.0-20250303144028-a0af3efb3deb // indirect
google.golang.org/genproto/googleapis/api v0.0.0-20250303144028-a0af3efb3deb // indirect
google.golang.org/genproto/googleapis/rpc v0.0.0-20250422160041-2d3770c4ea7f // indirect
google.golang.org/genproto/googleapis/api v0.0.0-20250324211829-b45e905df463 // indirect
google.golang.org/genproto/googleapis/rpc v0.0.0-20250603155806-513f23925822 // indirect
google.golang.org/protobuf v1.36.6 // indirect
gopkg.in/evanphx/json-patch.v4 v4.12.0 // indirect
gopkg.in/inf.v0 v0.9.1 // indirect
Expand All @@ -185,10 +185,6 @@ require (
sigs.k8s.io/yaml v1.4.0 // indirect
)

// v1.64.0 brings in go1.23, which we aren't ready to go to just yet
// issue: https://github.com/operator-framework/operator-lifecycle-manager/issues/3284
replace google.golang.org/grpc => google.golang.org/grpc v1.63.2

// cel-go v0.23.0 upgrade causes errors raised from the vendor source which lead to think in
// incompatibilities scenarios. After upgrade to use the latest versions of k8s/api v0.33+
// we should try to see if we could fix this one and remove this replace
Expand Down
2,412 changes: 36 additions & 2,376 deletions go.sum

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion pkg/controller/registry/grpc/source.go
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ func grpcConnection(address string) (*grpc.ClientConn, error) {
}))
}

return grpc.Dial(address, dialOptions...)
return grpc.NewClient(address, dialOptions...)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we should make this change. I see that grpc.Dial is deprecated, but reading the GoDoc of grpc.DialContext (which is called by grpc.Dial), it sounds like there are subtle differences that may matter to us:

https://github.com/grpc/grpc-go/blob/c52d02553f2649c28d0279bca17909a3a08de022/clientconn.go#L228-L236

// One subtle difference between NewClient and Dial and DialContext is that the
// former uses "dns" as the default name resolver, while the latter use
// "passthrough" for backward compatibility. This distinction should not matter
// to most users, but could matter to legacy users that specify a custom dialer
// and expect it to receive the target string directly.

We do use a custom dialer if there is a proxyURL.

}

func (s *SourceStore) Add(key registry.CatalogKey, address string) (*SourceConn, error) {
Expand Down
2 changes: 1 addition & 1 deletion pkg/package-server/provider/registry_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -2067,7 +2067,7 @@ func TestRegistryProviderListLabels(t *testing.T) {
}

func newTestRegistryClient(t *testing.T, catsrc *operatorsv1alpha1.CatalogSource) *registryClient {
conn, err := grpc.Dial(address+catsrc.Status.RegistryServiceStatus.Port, grpc.WithTransportCredentials(insecure.NewCredentials()))
conn, err := grpc.NewClient(address+catsrc.Status.RegistryServiceStatus.Port, grpc.WithTransportCredentials(insecure.NewCredentials()))
require.NoError(t, err, "could not set up test grpc connection")
return newRegistryClient(catsrc, conn)
}
1 change: 1 addition & 0 deletions vendor/go.opentelemetry.io/otel/.gitignore

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

103 changes: 15 additions & 88 deletions vendor/go.opentelemetry.io/otel/.golangci.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

44 changes: 43 additions & 1 deletion vendor/go.opentelemetry.io/otel/CHANGELOG.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 12 additions & 0 deletions vendor/go.opentelemetry.io/otel/CONTRIBUTING.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading