🌱 update skopeo openshift test #3298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perdasilva
changed the title
Signed-off-by: Per Goncalves da Silva <[email protected]>
perdasilva
force-pushed
the
fix/skopeo-e2e
branch
from
296eba4 to
61e4abc
Compare
perdasilva
commented
May 30, 2024
| Expect(err).Should(BeNil()) | ||
|
|
||
| By("waiting for the subscription to have v0.3.0 installed with a Package deprecated condition") | ||
| By("waiting for the subscription to have v0.3.0 installed without a bundle deprecated condition") |
Collaborator
Author
There was a problem hiding this comment.
What this test really wants to test is that bundle deprecation condition is gone. So, let's just test for that.
Member
|
If this is the fastest way to handle this, I'm not opposed to the change, but is there a reason we can't shift openshift specific stuff out of this repository entirely? |
perdasilva
force-pushed
the
fix/skopeo-e2e
branch
from
61e4abc to
b606c14
Compare
Collaborator
Author
I have that on my list of things. Let's deal with getting downstream green first though and yanks this out as it's own task. |
Signed-off-by: Per Goncalves da Silva <[email protected]>
perdasilva
force-pushed
the
fix/skopeo-e2e
branch
from
b606c14 to
a937352
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
This update does not affect OLM. This updates an e2e test that is used downstream by Red Hat. This PR updates the version of skopeo used in the test as well as the way the skopeo pod is built for it. Now, we mount the secret as a volume and convert its contents to an auth.json file that skopeo can use and also mount an emptydir as a local cache for skopeo (something the logs showed skopeo was complaining about). I've reproduced this issue and tested this fix using an Openshift cluster.
Motivation for the change:
The test expected Openshift to add credential annotations in a secret that contains the auth configuration for the internal registry.
Architectural changes:
Testing remarks:
Reviewer Checklist
/doc[FLAKE]are truly flaky and have an issue