-
Notifications
You must be signed in to change notification settings - Fork 64
🌱 Consolidate e2e CI jobs #993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,6 +9,19 @@ on: | |
- main | ||
|
||
jobs: | ||
extension-developer-e2e: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v4 | ||
|
||
- uses: actions/setup-go@v5 | ||
with: | ||
go-version-file: go.mod | ||
|
||
- name: Run the extension developer e2e test | ||
run: | | ||
make extension-developer-e2e | ||
|
||
e2e-kind: | ||
runs-on: ubuntu-latest | ||
steps: | ||
|
@@ -21,14 +34,7 @@ jobs: | |
go-version-file: go.mod | ||
|
||
- name: Run e2e tests | ||
run: | | ||
# By default make stops building on first non-zero exit code which | ||
# in case of E2E tests will mean that code coverage will only be | ||
# collected on successful runs. We want to collect coverage even | ||
# after failing tests. | ||
# With -k flag make will continue the build, but will return non-zero | ||
# exit code in case of any errors. | ||
ARTIFACT_PATH=/tmp/artifacts make test-e2e | ||
run: ARTIFACT_PATH=/tmp/artifacts make test-e2e | ||
|
||
- uses: cytopia/[email protected] | ||
if: failure() | ||
|
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This commit is not longer relevant since at some point
-k
was removed.