Skip to content

Conversation

tmshort
Copy link
Contributor

@tmshort tmshort commented May 1, 2024

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Signed-off-by: Todd Short <[email protected]>
@tmshort tmshort requested a review from a team as a code owner May 1, 2024 18:19
Copy link
Member

@varshaprasad96 varshaprasad96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 1, 2024
@tmshort tmshort merged commit 04348ac into operator-framework:helm-poc May 1, 2024
@tmshort tmshort deleted the helm-poc branch May 1, 2024 20:08
varshaprasad96 pushed a commit to varshaprasad96/operator-controller that referenced this pull request May 2, 2024
Signed-off-by: Todd Short <[email protected]>
Signed-off-by: Varsha Prasad Narsing <[email protected]>
varshaprasad96 pushed a commit to varshaprasad96/operator-controller that referenced this pull request May 2, 2024
tmshort added a commit that referenced this pull request May 3, 2024
plug in resolver

Deal with removal of HigherBundleVersion

Removed in e079129

Signed-off-by: Todd Short <[email protected]>

:sparkles: Starting Helm POC - pull in some rukpak (#756)

* Fix suite_test.go

Signed-off-by: Todd Short <[email protected]>

* Copy over some rukpak code and replace BundleDeployment

Replace BundleDeployment in the Unpack APIs with a combination of
BundleSource and ClusterExtension.

It builds...

Signed-off-by: Todd Short <[email protected]>

* fixup! Copy over some rukpak code and replace BundleDeployment

---------

Signed-off-by: Todd Short <[email protected]>

Plugin unpacker, add Handler (#757)

Signed-off-by: Varsha Prasad Narsing <[email protected]>
Co-authored-by: [email protected] <[email protected]>

A bit of cleanup (#761)

Signed-off-by: Todd Short <[email protected]>

:warning: Install the helm chart (#762)

* Install the helm chart

Signed-off-by: Todd Short <[email protected]>

* fixup! Install the helm chart

Signed-off-by: Todd Short <[email protected]>

---------

Signed-off-by: Todd Short <[email protected]>

Set up right watches and all labels to postrenderer (#763)

Co-authored-by: [email protected] <[email protected]>

:warning: Update owner keys (#765)

* Update owner keys

Signed-off-by: Todd Short <[email protected]>

* fixup! Update owner keys

Signed-off-by: Todd Short <[email protected]>

---------

Signed-off-by: Todd Short <[email protected]>

No more panics (#767)

Signed-off-by: Todd Short <[email protected]>

Add relevant RBAC to enable controller to watch resources (#776)

Co-authored-by: [email protected] <[email protected]>

Changes required for ClusterExtension to install an operator  (#789)

* Add relevant RBAC to enable controller to watch resources

* Debugging iteration - one

* ClusterExtension installing the operator - working

---------

Co-authored-by: [email protected] <[email protected]>

Fix some lints (#793)

Signed-off-by: Todd Short <[email protected]>

:sparkles: Getting cluster extension running (#795)

* Getting cluster extension running

* Specify namespace to create secret

Set resolved and installed versions (#806)

Remove install references to rukpak (#805)

Signed-off-by: Todd Short <[email protected]>

Consolidate error message generation (#807)

Signed-off-by: Todd Short <[email protected]>

Add make kind-redeploy (#808)

Signed-off-by: Todd Short <[email protected]>

Use rukpak as a library (#821)

Signed-off-by: Todd Short <[email protected]>

Improve caching and fix constant reconciles (#825)

Improve performance by caching objects that only have ClusterExtension
as owners.

Signed-off-by: Varsha Prasad Narsing <[email protected]>

Fix linter (#826)

Signed-off-by: Varsha Prasad Narsing <[email protected]>

Move helm-operator-plugin (#828)

Signed-off-by: Todd Short <[email protected]>

Really fix linter (#833)

Signed-off-by: Todd Short <[email protected]>
@tmshort tmshort mentioned this pull request May 3, 2024
4 tasks
tmshort added a commit that referenced this pull request May 6, 2024
plug in resolver

Deal with removal of HigherBundleVersion

Removed in e079129

Signed-off-by: Todd Short <[email protected]>

:sparkles: Starting Helm POC - pull in some rukpak (#756)

* Fix suite_test.go

Signed-off-by: Todd Short <[email protected]>

* Copy over some rukpak code and replace BundleDeployment

Replace BundleDeployment in the Unpack APIs with a combination of
BundleSource and ClusterExtension.

It builds...

Signed-off-by: Todd Short <[email protected]>

* fixup! Copy over some rukpak code and replace BundleDeployment

---------

Signed-off-by: Todd Short <[email protected]>

Plugin unpacker, add Handler (#757)

Signed-off-by: Varsha Prasad Narsing <[email protected]>
Co-authored-by: [email protected] <[email protected]>

A bit of cleanup (#761)

Signed-off-by: Todd Short <[email protected]>

:warning: Install the helm chart (#762)

* Install the helm chart

Signed-off-by: Todd Short <[email protected]>

* fixup! Install the helm chart

Signed-off-by: Todd Short <[email protected]>

---------

Signed-off-by: Todd Short <[email protected]>

Set up right watches and all labels to postrenderer (#763)

Co-authored-by: [email protected] <[email protected]>

:warning: Update owner keys (#765)

* Update owner keys

Signed-off-by: Todd Short <[email protected]>

* fixup! Update owner keys

Signed-off-by: Todd Short <[email protected]>

---------

Signed-off-by: Todd Short <[email protected]>

No more panics (#767)

Signed-off-by: Todd Short <[email protected]>

Add relevant RBAC to enable controller to watch resources (#776)

Co-authored-by: [email protected] <[email protected]>

Changes required for ClusterExtension to install an operator  (#789)

* Add relevant RBAC to enable controller to watch resources

* Debugging iteration - one

* ClusterExtension installing the operator - working

---------

Co-authored-by: [email protected] <[email protected]>

Fix some lints (#793)

Signed-off-by: Todd Short <[email protected]>

:sparkles: Getting cluster extension running (#795)

* Getting cluster extension running

* Specify namespace to create secret

Set resolved and installed versions (#806)

Remove install references to rukpak (#805)

Signed-off-by: Todd Short <[email protected]>

Consolidate error message generation (#807)

Signed-off-by: Todd Short <[email protected]>

Add make kind-redeploy (#808)

Signed-off-by: Todd Short <[email protected]>

Use rukpak as a library (#821)

Signed-off-by: Todd Short <[email protected]>

Improve caching and fix constant reconciles (#825)

Improve performance by caching objects that only have ClusterExtension
as owners.

Signed-off-by: Varsha Prasad Narsing <[email protected]>

Fix linter (#826)

Signed-off-by: Varsha Prasad Narsing <[email protected]>

Move helm-operator-plugin (#828)

Signed-off-by: Todd Short <[email protected]>

Really fix linter (#833)

Signed-off-by: Todd Short <[email protected]>
varshaprasad96 pushed a commit to varshaprasad96/operator-controller that referenced this pull request May 10, 2024
plug in resolver

Deal with removal of HigherBundleVersion

Removed in e079129

Signed-off-by: Todd Short <[email protected]>

:sparkles: Starting Helm POC - pull in some rukpak (operator-framework#756)

* Fix suite_test.go

Signed-off-by: Todd Short <[email protected]>

* Copy over some rukpak code and replace BundleDeployment

Replace BundleDeployment in the Unpack APIs with a combination of
BundleSource and ClusterExtension.

It builds...

Signed-off-by: Todd Short <[email protected]>

* fixup! Copy over some rukpak code and replace BundleDeployment

---------

Signed-off-by: Todd Short <[email protected]>

Plugin unpacker, add Handler (operator-framework#757)

Signed-off-by: Varsha Prasad Narsing <[email protected]>
Co-authored-by: [email protected] <[email protected]>

A bit of cleanup (operator-framework#761)

Signed-off-by: Todd Short <[email protected]>

:warning: Install the helm chart (operator-framework#762)

* Install the helm chart

Signed-off-by: Todd Short <[email protected]>

* fixup! Install the helm chart

Signed-off-by: Todd Short <[email protected]>

---------

Signed-off-by: Todd Short <[email protected]>

Set up right watches and all labels to postrenderer (operator-framework#763)

Co-authored-by: [email protected] <[email protected]>

:warning: Update owner keys (operator-framework#765)

* Update owner keys

Signed-off-by: Todd Short <[email protected]>

* fixup! Update owner keys

Signed-off-by: Todd Short <[email protected]>

---------

Signed-off-by: Todd Short <[email protected]>

No more panics (operator-framework#767)

Signed-off-by: Todd Short <[email protected]>

Add relevant RBAC to enable controller to watch resources (operator-framework#776)

Co-authored-by: [email protected] <[email protected]>

Changes required for ClusterExtension to install an operator  (operator-framework#789)

* Add relevant RBAC to enable controller to watch resources

* Debugging iteration - one

* ClusterExtension installing the operator - working

---------

Co-authored-by: [email protected] <[email protected]>

Fix some lints (operator-framework#793)

Signed-off-by: Todd Short <[email protected]>

:sparkles: Getting cluster extension running (operator-framework#795)

* Getting cluster extension running

* Specify namespace to create secret

Set resolved and installed versions (operator-framework#806)

Remove install references to rukpak (operator-framework#805)

Signed-off-by: Todd Short <[email protected]>

Consolidate error message generation (operator-framework#807)

Signed-off-by: Todd Short <[email protected]>

Add make kind-redeploy (operator-framework#808)

Signed-off-by: Todd Short <[email protected]>

Use rukpak as a library (operator-framework#821)

Signed-off-by: Todd Short <[email protected]>

Improve caching and fix constant reconciles (operator-framework#825)

Improve performance by caching objects that only have ClusterExtension
as owners.

Signed-off-by: Varsha Prasad Narsing <[email protected]>

Fix linter (operator-framework#826)

Signed-off-by: Varsha Prasad Narsing <[email protected]>

Move helm-operator-plugin (operator-framework#828)

Signed-off-by: Todd Short <[email protected]>

Really fix linter (operator-framework#833)

Signed-off-by: Todd Short <[email protected]>
tmshort added a commit that referenced this pull request May 11, 2024
plug in resolver

Deal with removal of HigherBundleVersion

Removed in e079129

Signed-off-by: Todd Short <[email protected]>

:sparkles: Starting Helm POC - pull in some rukpak (#756)

* Fix suite_test.go

Signed-off-by: Todd Short <[email protected]>

* Copy over some rukpak code and replace BundleDeployment

Replace BundleDeployment in the Unpack APIs with a combination of
BundleSource and ClusterExtension.

It builds...

Signed-off-by: Todd Short <[email protected]>

* fixup! Copy over some rukpak code and replace BundleDeployment

---------

Signed-off-by: Todd Short <[email protected]>

Plugin unpacker, add Handler (#757)

Signed-off-by: Varsha Prasad Narsing <[email protected]>
Co-authored-by: [email protected] <[email protected]>

A bit of cleanup (#761)

Signed-off-by: Todd Short <[email protected]>

:warning: Install the helm chart (#762)

* Install the helm chart

Signed-off-by: Todd Short <[email protected]>

* fixup! Install the helm chart

Signed-off-by: Todd Short <[email protected]>

---------

Signed-off-by: Todd Short <[email protected]>

Set up right watches and all labels to postrenderer (#763)

Co-authored-by: [email protected] <[email protected]>

:warning: Update owner keys (#765)

* Update owner keys

Signed-off-by: Todd Short <[email protected]>

* fixup! Update owner keys

Signed-off-by: Todd Short <[email protected]>

---------

Signed-off-by: Todd Short <[email protected]>

No more panics (#767)

Signed-off-by: Todd Short <[email protected]>

Add relevant RBAC to enable controller to watch resources (#776)

Co-authored-by: [email protected] <[email protected]>

Changes required for ClusterExtension to install an operator  (#789)

* Add relevant RBAC to enable controller to watch resources

* Debugging iteration - one

* ClusterExtension installing the operator - working

---------

Co-authored-by: [email protected] <[email protected]>

Fix some lints (#793)

Signed-off-by: Todd Short <[email protected]>

:sparkles: Getting cluster extension running (#795)

* Getting cluster extension running

* Specify namespace to create secret

Set resolved and installed versions (#806)

Remove install references to rukpak (#805)

Signed-off-by: Todd Short <[email protected]>

Consolidate error message generation (#807)

Signed-off-by: Todd Short <[email protected]>

Add make kind-redeploy (#808)

Signed-off-by: Todd Short <[email protected]>

Use rukpak as a library (#821)

Signed-off-by: Todd Short <[email protected]>

Improve caching and fix constant reconciles (#825)

Improve performance by caching objects that only have ClusterExtension
as owners.

Signed-off-by: Varsha Prasad Narsing <[email protected]>

Fix linter (#826)

Signed-off-by: Varsha Prasad Narsing <[email protected]>

Move helm-operator-plugin (#828)

Signed-off-by: Todd Short <[email protected]>

Really fix linter (#833)

Signed-off-by: Todd Short <[email protected]>
bentito pushed a commit that referenced this pull request May 14, 2024
plug in resolver

Deal with removal of HigherBundleVersion

Removed in e079129

Signed-off-by: Todd Short <[email protected]>

:sparkles: Starting Helm POC - pull in some rukpak (#756)

* Fix suite_test.go

Signed-off-by: Todd Short <[email protected]>

* Copy over some rukpak code and replace BundleDeployment

Replace BundleDeployment in the Unpack APIs with a combination of
BundleSource and ClusterExtension.

It builds...

Signed-off-by: Todd Short <[email protected]>

* fixup! Copy over some rukpak code and replace BundleDeployment

---------

Signed-off-by: Todd Short <[email protected]>

Plugin unpacker, add Handler (#757)

Signed-off-by: Varsha Prasad Narsing <[email protected]>
Co-authored-by: [email protected] <[email protected]>

A bit of cleanup (#761)

Signed-off-by: Todd Short <[email protected]>

:warning: Install the helm chart (#762)

* Install the helm chart

Signed-off-by: Todd Short <[email protected]>

* fixup! Install the helm chart

Signed-off-by: Todd Short <[email protected]>

---------

Signed-off-by: Todd Short <[email protected]>

Set up right watches and all labels to postrenderer (#763)

Co-authored-by: [email protected] <[email protected]>

:warning: Update owner keys (#765)

* Update owner keys

Signed-off-by: Todd Short <[email protected]>

* fixup! Update owner keys

Signed-off-by: Todd Short <[email protected]>

---------

Signed-off-by: Todd Short <[email protected]>

No more panics (#767)

Signed-off-by: Todd Short <[email protected]>

Add relevant RBAC to enable controller to watch resources (#776)

Co-authored-by: [email protected] <[email protected]>

Changes required for ClusterExtension to install an operator  (#789)

* Add relevant RBAC to enable controller to watch resources

* Debugging iteration - one

* ClusterExtension installing the operator - working

---------

Co-authored-by: [email protected] <[email protected]>

Fix some lints (#793)

Signed-off-by: Todd Short <[email protected]>

:sparkles: Getting cluster extension running (#795)

* Getting cluster extension running

* Specify namespace to create secret

Set resolved and installed versions (#806)

Remove install references to rukpak (#805)

Signed-off-by: Todd Short <[email protected]>

Consolidate error message generation (#807)

Signed-off-by: Todd Short <[email protected]>

Add make kind-redeploy (#808)

Signed-off-by: Todd Short <[email protected]>

Use rukpak as a library (#821)

Signed-off-by: Todd Short <[email protected]>

Improve caching and fix constant reconciles (#825)

Improve performance by caching objects that only have ClusterExtension
as owners.

Signed-off-by: Varsha Prasad Narsing <[email protected]>

Fix linter (#826)

Signed-off-by: Varsha Prasad Narsing <[email protected]>

Move helm-operator-plugin (#828)

Signed-off-by: Todd Short <[email protected]>

Really fix linter (#833)

Signed-off-by: Todd Short <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants