Skip to content

🐛 Replace one last CONTAINER_RUNTIME in make #782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 25, 2024
Merged

🐛 Replace one last CONTAINER_RUNTIME in make #782

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a50055
Replace one last CONTAINER_RUNTIME in make
bentito Apr 24, 2024
9e414d7
Workaround for podman for kind load
bentito Apr 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,15 @@ e2e-coverage:

.PHONY: kind-load
kind-load: $(KIND) #EXHELP Loads the currently constructed image onto the cluster.
ifeq ($(CONTAINER_RUNTIME),podman)
@echo "Using Podman"
podman save $(IMG) -o $(IMG).tar
$(KIND) load image-archive $(IMG).tar --name $(KIND_CLUSTER_NAME)
rm $(IMG).tar
else
@echo "Using Docker"
$(KIND) load docker-image $(IMG) --name $(KIND_CLUSTER_NAME)
endif

kind-deploy: export MANIFEST="./operator-controller.yaml"
kind-deploy: manifests $(KUSTOMIZE) #EXHELP Install controller and dependencies onto the kind cluster.
Expand Down Expand Up @@ -215,7 +223,7 @@ run: docker-build kind-cluster kind-load kind-deploy #HELP Build the operator-co

.PHONY: docker-build
docker-build: build-linux #EXHELP Build docker image for operator-controller with GOOS=linux and local GOARCH.
docker build -t ${IMG} -f Dockerfile ./bin/linux
$(CONTAINER_RUNTIME) build -t ${IMG} -f Dockerfile ./bin/linux

#SECTION Release

Expand Down