Skip to content

🐛 Replace one last CONTAINER_RUNTIME in make #782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

bentito
Copy link
Contributor

@bentito bentito commented Apr 24, 2024

Description

Seems like one instance of CONTAINER_RUNTIME was missed so that it still was not possible to choose the container runtime for make docker-build

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@bentito bentito requested a review from a team as a code owner April 24, 2024 20:08
Copy link

netlify bot commented Apr 24, 2024

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 9e414d7
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/66296ab50a1ad200087d2714
😎 Deploy Preview https://deploy-preview-782--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.16%. Comparing base (189b42a) to head (9e414d7).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #782   +/-   ##
=======================================
  Coverage   67.16%   67.16%           
=======================================
  Files          22       22           
  Lines        1465     1465           
=======================================
  Hits          984      984           
  Misses        415      415           
  Partials       66       66           
Flag Coverage Δ
e2e 45.46% <ø> (ø)
unit 61.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@perdasilva perdasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ^^

@perdasilva perdasilva added this pull request to the merge queue Apr 25, 2024
Merged via the queue into operator-framework:main with commit b4c66de Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants