Skip to content

Add ForceSemverUpgradeConstraints feature gate #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

m1kola
Copy link
Member

@m1kola m1kola commented Oct 5, 2023

Description

Closes #395

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 5, 2023
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (65bfc69) 84.00% compared to head (c9a87a5) 83.76%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #438      +/-   ##
==========================================
- Coverage   84.00%   83.76%   -0.24%     
==========================================
  Files          23       23              
  Lines         844      844              
==========================================
- Hits          709      707       -2     
- Misses         93       94       +1     
- Partials       42       43       +1     
Flag Coverage Δ
e2e 65.87% <ø> (-0.24%) ⬇️
unit 76.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/features/features.go 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@m1kola m1kola marked this pull request as ready for review October 5, 2023 12:48
@m1kola m1kola requested a review from a team as a code owner October 5, 2023 12:48
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 5, 2023
@m1kola m1kola marked this pull request as draft October 5, 2023 16:19
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 5, 2023
@m1kola m1kola marked this pull request as ready for review October 6, 2023 09:02
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 6, 2023
@m1kola m1kola requested a review from everettraven October 6, 2023 09:13
@m1kola m1kola added this pull request to the merge queue Oct 6, 2023
Merged via the queue into operator-framework:main with commit b8f3626 Oct 6, 2023
@m1kola m1kola deleted the 395_feature_gate branch October 31, 2023 11:33
LalatenduMohanty pushed a commit to LalatenduMohanty/operator-controller that referenced this pull request Dec 19, 2024
…perator-framework#438)

When used in conjuction with a "tag-only" registries.conf mirror
registry configuration, our containers/image unpacker fails. This is
because we resolve a canonical ref from the tag, and then use the
digest-based reference to actually copy the image, thus thwarting the
tag-only configuration.

This commit ensures that we always copy the image using the reference
provided in the spec.

Signed-off-by: Joe Lanford <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ForceSemverUpgradeConstraints feature gate
2 participants