✨ Bundle configuration is now validated - errors caught early with clear messages.

[camilamacedo86]

Summary

Bundle configuration is now validated using JSONSchema. Configuration
errors (typos, missing required fields, wrong types) are caught
immediately with clear error messages instead of failing during installation.

Motivation

https://issues.redhat.com/browse/OPRUN-4112

Criterias

Your Bundle Supports	Do You Need to Configure watchNamespace?
AllNamespaces	✅ No - config is optional
SingleNamespace	❌ Yes - you must specify which namespace
OwnNamespace	❌ Yes - you must specify the install namespace
Multiple modes including AllNamespaces	✅ No - config is optional
Multiple modes WITHOUT AllNamespaces	❌ Yes - you must pick a namespace

Examples

✅ Works - AllNamespaces bundle without config

kind: ClusterExtension
spec:
  packageName: my-operator
  # No config needed

✅ Works - OwnNamespace bundle with config

kind: ClusterExtension
spec:
  packageName: my-operator
  config:
    watchNamespace: my-namespace

❌ Fails - OwnNamespace bundle without config

kind: ClusterExtension
spec:
  packageName: my-operator
  # Error: required field "watchNamespace" is missing

❌ Fails - Invalid field

kind: ClusterExtension
spec:
  packageName: my-operator
  config:
    watchNamespce: my-namespace  # Typo
    # Error: unknown field "watchNamespce"

[netlify]

✅ Deploy Preview for olmv1 ready!

Name	Link
🔨 Latest commit	aaa71d0
🔍 Latest deploy log	https://app.netlify.com/projects/olmv1/deploys/6911c977afb9540008f9cf5d
😎 Deploy Preview	https://deploy-preview-2316--olmv1.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[codecov]

Codecov Report

❌ Patch coverage is 68.64865% with 58 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.06%. Comparing base (b3f85d5) to head (aaa71d0).

Files with missing lines	Patch %	Lines
...ternal/operator-controller/rukpak/bundle/config.go	68.64%	47 Missing and 11 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2316      +/-   ##
==========================================
+ Coverage   71.14%   74.06%   +2.91%     
==========================================
  Files          91       91              
  Lines        7046     7198     +152     
==========================================
+ Hits         5013     5331     +318     
+ Misses       1618     1446     -172     
- Partials      415      421       +6     

Flag	Coverage Δ
e2e	44.79% <0.00%> (-1.15%)	⬇️
experimental-e2e	48.34% <51.35%> (?)
unit	58.68% <68.64%> (+0.09%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign joelanford for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Copilot]

Pull Request Overview

This PR refactors bundle configuration validation to use JSON Schema for comprehensive validation rather than imperative Go code. The change moves all validation logic (structural checks, format validation, and install mode compatibility) into a dynamically generated JSON schema.

Key Changes:

• Replaces manual validation logic with JSON Schema-based validation using the jsonschema/v6 library
• Introduces schema generation functions that create validation rules tailored to bundle install modes
• Adds comprehensive error formatting to translate JSON schema validation errors into user-friendly messages

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File	Description
internal/operator-controller/rukpak/bundle/config.go	Complete rewrite of validation logic to use JSON Schema; adds schema generation, custom format validators, and error message formatting functions
internal/operator-controller/rukpak/bundle/config_test.go	Updates test cases to reflect new behavior where nil config is treated as {} for validation
go.mod	Moves github.com/santhosh-tekuri/jsonschema/v6 from indirect to direct dependency

Comments suppressed due to low confidence (1)

internal/operator-controller/rukpak/bundle/config.go:505

• [nitpick] The function substringBetween has a confusing parameter name finish that represents the index, not the end marker itself. The variable should be named endIdx to match the pattern used with begin → begin index calculation.

Consider renaming for consistency:

endIdx := strings.Index(remaining, end)
if endIdx == -1 {
    return ""
}
return remaining[:endIdx]

		return ""
	}
	return value[idx+len(token):]
}

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull Request Overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull Request Overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.