🐛 fix: boxcutter logging levels #2314

camilamacedo86 · 2025-11-08T23:16:53Z

Use Error level for all error conditions (validation, collision, engine failures)
Move verbose success reports to V(1) debug mode
Include full diagnostic reports when errors occur

netlify · 2025-11-08T23:16:59Z

✅ Deploy Preview for olmv1 ready!

Name	Link
🔨 Latest commit	`b621850`
🔍 Latest deploy log	https://app.netlify.com/projects/olmv1/deploys/6911d67d3d98c300077c02b4
😎 Deploy Preview	https://deploy-preview-2314--olmv1.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copilot

Pull Request Overview

This PR improves the logging strategy for the ClusterExtensionRevision controller by reducing verbosity and providing more actionable error messages. The changes shift detailed reconcile/teardown reports to debug-level logging while elevating validation and collision errors to error-level logging for better visibility.

Changed successful reconcile/teardown reports from info-level to debug-level (V(1))
Elevated preflight validation errors from info-level to error-level logging
Enhanced error logging for reconcile/teardown failures to include report details when available
Added phase context to validation and collision error messages

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

internal/operator-controller/controllers/clusterextensionrevision_controller.go

Copilot

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

codecov · 2025-11-08T23:42:21Z

Codecov Report

❌ Patch coverage is 53.84615% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.19%. Comparing base (b3f85d5) to head (b621850).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...controllers/clusterextensionrevision_controller.go	53.84%	3 Missing and 3 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2314      +/-   ##
==========================================
+ Coverage   71.14%   74.19%   +3.05%     
==========================================
  Files          91       91              
  Lines        7046     7054       +8     
==========================================
+ Hits         5013     5234     +221     
+ Misses       1618     1404     -214     
- Partials      415      416       +1

Flag	Coverage Δ
e2e	`45.80% <0.00%> (-0.14%)`	⬇️
experimental-e2e	`48.19% <38.46%> (?)`
unit	`58.53% <38.46%> (-0.06%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

perdasilva · 2025-11-10T10:36:08Z

internal/operator-controller/controllers/clusterextensionrevision_controller.go

+		if rres != nil {
+			l.Error(err, "revision reconcile failed", "report", rres.String())
+		} else {
+			l.Error(err, "revision reconcile failed")
+		}


I don't know if it's much of an improvement, but if we want to eliminate the duplication here we could do something like

Suggested change

if rres != nil {

l.Error(err, "revision reconcile failed", "report", rres.String())

} else {

l.Error(err, "revision reconcile failed")

}

var kvs []string

if rres != nil {

kvs = append(kvs, "report", rres.String())

}

l.Error(err, "revision reconcile failed", kvs...)

or something like that

Yep, we can done.

We need keep the explicity approach otehrwise will fail in the lint; https://github.com/operator-framework/operator-controller/actions/runs/19230041339/job/54966203269?pr=2314

perdasilva · 2025-11-10T10:36:34Z

/lgtm - just left a small suggestion for possible improvement

camilamacedo86 · 2025-11-10T11:27:46Z

@perdasilva all done.
So, I think this small one can fly :-)

- Use Error level for all error conditions (validation, collision, engine failures) - Move verbose success reports to V(1) debug mode - Include full diagnostic reports when errors occur

Copilot

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

openshift-ci · 2025-11-10T13:03:23Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~internal/operator-controller/OWNERS~~ [perdasilva]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tmshort · 2025-11-10T14:04:47Z

/override patch

openshift-ci · 2025-11-10T14:04:51Z

@tmshort: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

patch

Only the following failed contexts/checkruns were expected:

Verify PR title
codecov/patch
crd-diff
e2e-kind
extension-developer-e2e
go-apidiff
go-verdiff
goreleaser
lint
netlify/olmv1/deploy-preview
tide
unit-test-basic
upgrade-e2e
verify

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override patch

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tmshort · 2025-11-10T14:05:05Z

/override codecov/patch

openshift-ci · 2025-11-10T14:05:10Z

@tmshort: Overrode contexts on behalf of tmshort: codecov/patch

In response to this:

/override codecov/patch

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copilot AI review requested due to automatic review settings November 8, 2025 23:16

camilamacedo86 requested a review from a team as a code owner November 8, 2025 23:16

openshift-ci bot requested review from grokspawn and joelanford November 8, 2025 23:16

camilamacedo86 force-pushed the log-verbose branch from da24e61 to 423621d Compare November 8, 2025 23:22

camilamacedo86 changed the title ~~🐛 (fix): boxcutter logging~~ 🐛 fix: improve boxcutter logging levels Nov 8, 2025

Copilot AI reviewed Nov 8, 2025

View reviewed changes

internal/operator-controller/controllers/clusterextensionrevision_controller.go Outdated Show resolved Hide resolved

internal/operator-controller/controllers/clusterextensionrevision_controller.go Outdated Show resolved Hide resolved

camilamacedo86 force-pushed the log-verbose branch from 423621d to 2543dea Compare November 8, 2025 23:30

camilamacedo86 requested a review from Copilot November 8, 2025 23:30

Copilot AI reviewed Nov 8, 2025

View reviewed changes

camilamacedo86 changed the title ~~🐛 fix: improve boxcutter logging levels~~ 🐛 fix: boxcutter logging levels Nov 8, 2025

perdasilva reviewed Nov 10, 2025

View reviewed changes

camilamacedo86 force-pushed the log-verbose branch from 2543dea to 9f45e07 Compare November 10, 2025 11:27

camilamacedo86 requested a review from perdasilva November 10, 2025 11:28

fix: improve boxcutter logging levels

b621850

- Use Error level for all error conditions (validation, collision, engine failures) - Move verbose success reports to V(1) debug mode - Include full diagnostic reports when errors occur

camilamacedo86 force-pushed the log-verbose branch from 9f45e07 to b621850 Compare November 10, 2025 12:11

Copilot AI review requested due to automatic review settings November 10, 2025 12:11

Copilot AI reviewed Nov 10, 2025

View reviewed changes

perdasilva approved these changes Nov 10, 2025

View reviewed changes

openshift-ci bot assigned perdasilva Nov 10, 2025

openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 10, 2025

openshift-merge-bot bot merged commit d4e93be into operator-framework:main Nov 10, 2025
25 of 26 checks passed

🐛 fix: boxcutter logging levels #2314

🐛 fix: boxcutter logging levels #2314

Uh oh!

Conversation

camilamacedo86 commented Nov 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify bot commented Nov 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for olmv1 ready!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

codecov bot commented Nov 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

perdasilva Nov 10, 2025

Choose a reason for hiding this comment

Uh oh!

camilamacedo86 Nov 10, 2025

Choose a reason for hiding this comment

Uh oh!

camilamacedo86 Nov 10, 2025

Choose a reason for hiding this comment

Uh oh!

perdasilva commented Nov 10, 2025

Uh oh!

camilamacedo86 commented Nov 10, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

openshift-ci bot commented Nov 10, 2025

Uh oh!

tmshort commented Nov 10, 2025

Uh oh!

openshift-ci bot commented Nov 10, 2025

Uh oh!

tmshort commented Nov 10, 2025

Uh oh!

openshift-ci bot commented Nov 10, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

camilamacedo86 commented Nov 8, 2025 •

edited

Loading

netlify bot commented Nov 8, 2025 •

edited

Loading

codecov bot commented Nov 8, 2025 •

edited

Loading