🌱 Tidy up Makefile and remove convert-diff GHA #1900
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
joelanford
reviewed
Apr 4, 2025
Makefile
Outdated
Comment on lines
401
to
411
| build-docs: | ||
| . $(VENV)/activate; \ | ||
| mkdocs build | ||
|
|
||
| .PHONY: serve-docs | ||
| serve-docs: venv | ||
| serve-docs: | ||
| . $(VENV)/activate; \ | ||
| mkdocs serve | ||
|
|
||
| .PHONY: deploy-docs | ||
| deploy-docs: venv | ||
| deploy-docs: |
There was a problem hiding this comment.
What's the story here? Makefile.venv has some doc text that makes this sounds important.
There was a problem hiding this comment.
my bad - ide was complaining so I thought they were left over from a few months back when there was some makefile refactoring. I've put them back in.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1900 +/- ##
==========================================
- Coverage 69.27% 69.21% -0.06%
==========================================
Files 67 67
Lines 5302 5302
==========================================
- Hits 3673 3670 -3
- Misses 1397 1399 +2
- Partials 232 233 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
perdasilva
force-pushed
the
refactor-make
branch
from
3747b86 to
07b7980
Compare
Signed-off-by: Per Goncalves da Silva <[email protected]>
perdasilva
force-pushed
the
refactor-make
branch
from
07b7980 to
144e8d9
Compare
joelanford
approved these changes
Apr 4, 2025
Merged
via the queue into
operator-framework:main
with commit Apr 4, 2025
115a122
18 of 19 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tidies up the Makefile by combining the bundle manifest generation recipe with verify.
We also remove the convert-diff GHA in favor or running the test in the verify GHA
Reviewer Checklist