Skip to content

Conversation

tmshort
Copy link
Contributor

@tmshort tmshort commented Feb 14, 2025

Do ctrl.SetLogger() in init()
Check klog.V(4).Enabled() in run() (after flags have been parsed)

Closes: #1556

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Do ctrl.SetLogger() in init()
Check klog.V(4).Enabled() in run() (after flags have been parsed)

Signed-off-by: Todd Short <[email protected]>
@tmshort tmshort requested a review from a team as a code owner February 14, 2025 18:21
Copy link

netlify bot commented Feb 14, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 5127085
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/67af89c324139800089da1db
😎 Deploy Preview https://deploy-preview-1779--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Feb 14, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 68.34%. Comparing base (0e9673b) to head (5127085).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cmd/operator-controller/main.go 40.00% 2 Missing and 1 partial ⚠️
catalogd/cmd/catalogd/main.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1779      +/-   ##
==========================================
+ Coverage   68.32%   68.34%   +0.01%     
==========================================
  Files          63       63              
  Lines        5115     5117       +2     
==========================================
+ Hits         3495     3497       +2     
  Misses       1390     1390              
  Partials      230      230              
Flag Coverage Δ
e2e 51.62% <40.00%> (-0.06%) ⬇️
unit 55.91% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tmshort tmshort added this pull request to the merge queue Feb 14, 2025
Merged via the queue into operator-framework:main with commit 237ec1c Feb 14, 2025
22 of 23 checks passed
@tmshort tmshort deleted the logger branch February 14, 2025 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix issues with logging flag validations
2 participants