📖 Derive minimal service account needed to install a bundle #1238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
trgeiger
reviewed
Sep 9, 2024
trgeiger
reviewed
Sep 9, 2024
LalatenduMohanty
requested changes
Sep 9, 2024
rashmi43
changed the title
rashmi43
changed the title
trgeiger
reviewed
Sep 11, 2024
rashmi43
changed the title
grokspawn
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1238 +/- ##
==========================================
+ Coverage 75.99% 76.17% +0.17%
==========================================
Files 41 41
Lines 2429 2409 -20
==========================================
- Hits 1846 1835 -11
+ Misses 410 401 -9
Partials 173 173
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
trgeiger
reviewed
Sep 12, 2024
trgeiger
reviewed
Sep 12, 2024
trgeiger
reviewed
Sep 12, 2024
trgeiger
reviewed
Sep 12, 2024
trgeiger
reviewed
Sep 12, 2024
trgeiger
suggested changes
Sep 12, 2024
trgeiger
reviewed
Sep 13, 2024
trgeiger
reviewed
Sep 13, 2024
Signed-off-by: rashmi_kh <[email protected]>
Signed-off-by: rashmi_kh <[email protected]>
Signed-off-by: rashmi_kh <[email protected]>
Signed-off-by: rashmi_kh <[email protected]>
Signed-off-by: rashmi_kh <[email protected]>
Signed-off-by: rashmi_kh <[email protected]>
Signed-off-by: rashmi_kh <[email protected]>
Signed-off-by: rashmi_kh <[email protected]>
Signed-off-by: rashmi_kh <[email protected]>
Signed-off-by: rashmi_kh <[email protected]>
Signed-off-by: rashmi_kh <[email protected]>
Signed-off-by: rashmi_kh <[email protected]>
Signed-off-by: rashmi_kh <[email protected]>
Signed-off-by: rashmi_kh <[email protected]>
Signed-off-by: rashmi_kh <[email protected]>
Signed-off-by: rashmi_kh <[email protected]>
Signed-off-by: rashmi_kh <[email protected]>
Signed-off-by: rashmi_kh <[email protected]>
Signed-off-by: rashmi_kh <[email protected]>
perdasilva
force-pushed
the
derive-serviceaccount
branch
2 times, most recently
from
51461dd to
6985222
Compare
Signed-off-by: rashmi_kh <[email protected]> Signed-off-by: Per Goncalves da Silva <[email protected]>
perdasilva
force-pushed
the
derive-serviceaccount
branch
from
6985222 to
c9e97f7
Compare
perdasilva
approved these changes
Oct 1, 2024
Would not have been possible without your support. Really appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation on how to derive the minimal roles required to install cluster extensions
Fixes: #1130
Description
Reviewer Checklist